-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add failing/flaking test issue templates to the repository #7778
🌱 Add failing/flaking test issue templates to the repository #7778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea and something successive release teams can refine over time. Can we also add a task for the release team (maybe as the responsibility of the CI lead but the team can decide that) to maintain and review these templates?
I'm happy with adding them, but it's a good idea to have a defined role for maintaining and keeping these up to date as needed.
2136a90
to
c4d70ab
Compare
@killianmuldoon thanks for the review, I totally agree with the point. I have added it as part of the CI lead responsibilities which makes more sense IMO, PTAL, but I will wait for others' opinions as well. /cc @fabriziopandini |
337d574
to
e9592f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea. 👍🏼
We can refine the template over time as we start using them but this is a great start.
e9592f4
to
989c7b5
Compare
Labels were added automatically after review comment, removing them. |
/remove-kind failing-test |
Let's give it a try! Also +1 from my side to switch to GitHub forms in a follow-up PR |
LGTM label has been added. Git tree hash: bbcee8bea0c0df9b44dfc9eb52b810c09ad5a0df
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini great to hear that, I created a separate issue #7815 to track it. |
I'm late to the party but I love this, thanks for doing this @furkatgofurov7 🙏 |
What this PR does / why we need it:
While we can still modify existing issue templates when reporting CI related issues, it would be very helpful if we could have issue templates ready while opening
failing/flaking test
issues in the repository (especially handy for relase team CI signal members) similar to the one used in the k8s repo, as IMO it helps to:Note: I am still using the markdown formatted issue templates for new failing/flaking-test templates in this PR but we have a possibility to move all existing templates from markdown format to GitHub forms for issue templates which basically YAML representation of the template.
Example issue template in kubernetes repo to get the idea how it looks like: https://github.com/kubernetes/kubernetes/issues/new?assignees=&labels=kind%2Ffailing-test&template=failing-test.yaml
k/k repo has already switched to the GitHub forms in kubernetes/kubernetes#104468. We can replace all templates with the GitHub forms if agreed and if not we could still stick to the markdown format as well (since the feature itself seems still in beta).