Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use latest kind images for CAPD #7621

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7620

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2022
@sbueringer
Copy link
Member Author

/assign @killianmuldoon
/assign @fabriziopandini

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/assign @killianmuldoon
/assign @fabriziopandini

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@fabriziopandini
Copy link
Member

Thanks for this change!
What about tracking this somehow on our release task list, so we periodically check we are running recent images?
cc @sbueringer @ykakarap
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit b292922 into kubernetes-sigs:main Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 28, 2022
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #7644

In response to this:

/assign @killianmuldoon
/assign @fabriziopandini

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

sbueringer commented Nov 28, 2022

@fabriziopandini I have "Ensure the latest available kind version is used as well." as part of our Kubernetes bump tracking issue: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/ISSUE_TEMPLATE/kubernetes_bump.md

I can add: ensure the latest kind images are used as a hint there as well.

I think I wouldn't add it on both lists as it's usually important in the context of the Kubernetes bump.

Context:

Usually it's like this: new Kubernetes release => new kind release (as part of that: new kind images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use latest kind image in CAPD e2e tests
5 participants