Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add the quickstart details for KubeVirt #7444

Merged
merged 1 commit into from
Nov 17, 2022
Merged

📖 Add the quickstart details for KubeVirt #7444

merged 1 commit into from
Nov 17, 2022

Conversation

nunnatsa
Copy link
Contributor

@nunnatsa nunnatsa commented Oct 23, 2022 •
edited
Loading

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Fixes kubernetes-sigs/cluster-api-provider-kubevirt#36

What this PR does / why we need it:
This PR add many details for the quickstart guide, to explain how to deploy a guest cluster using the KubeVirt provider.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2022
@nunnatsa nunnatsa changed the title Add the quickstart details for KubeVirt 📖 Add the quickstart details for KubeVirt Oct 23, 2022
@nunnatsa
Copy link
Contributor Author

/cc @davidvossel

@nunnatsa nunnatsa force-pushed the book-kubevirt branch 5 times, most recently from 046b131 to 52090b5 Compare October 24, 2022 08:22
sbueringer
sbueringer reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

Thank you very much for adding more documentation!

docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
davidvossel
davidvossel approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I went through all these instructions and it worked perfect for me locally.

docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022
@davidvossel
Copy link
Contributor

/lgtm

@davidvossel
Copy link
Contributor

@sbueringer would you be able to take another look at this? I ran through the steps locally and it works for me. Now, we need an approve. Thanks!

@enxebre
Copy link
Member

enxebre commented Oct 31, 2022

Thanks!
/lgtm
for Stefan to have the final look.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2022
sbueringer
sbueringer reviewed Oct 31, 2022
View reviewed changes
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated
export CAPK_GUEST_K8S_VERSION="${CAPK_GUEST_K8S_VERSION:-v1.23.10}"
export CRI_PATH="${CRI_PATH:-/var/run/containerd/containerd.sock}"
export NODE_VM_IMAGE_TEMPLATE="${NODE_VM_IMAGE_TEMPLATE:-quay.io/capk/ubuntu-2004-container-disk:${CAPK_GUEST_K8S_VERSION}}"
export IMAGE_REPO="${IMAGE_REPO:-k8s.gcr.io}"
Copy link
Member

@sbueringer sbueringer Oct 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, please follow-up on this after the PR. Kubernetes is literally running out of money with the old registry. So we're trying everything we can going forward to use the new registry as it's cheaper.

sbueringer
sbueringer reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nit from my side

cc @fabriziopandini

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2022
@sbueringer
Copy link
Member

/lgtm

I would like a review from Fabrizio as well

/assign @fabriziopandini

@nunnatsa nunnatsa requested review from fabriziopandini and davidvossel and removed request for sbueringer, fabriziopandini and davidvossel November 16, 2022 06:34
@sbueringer
Copy link
Member

@nunnatsa Just one last nit from my side.

Very very nice :) Happy to see this land.

Appreciate your patience in addressing the review comments!!

@sbueringer
Copy link
Member

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@nunnatsa
Add the quickstart details for KubeVirt
c1fe228 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
g-gaston
g-gaston approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabriziopandini
Copy link
Member

Great Job!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit cfdc9cd into kubernetes-sigs:main Nov 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 17, 2022
@nunnatsa nunnatsa deleted the book-kubevirt branch November 17, 2022 13:58
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 17, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7557

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 17, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7558

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@sbueringer sbueringer sbueringer left review comments

@davidvossel davidvossel davidvossel approved these changes

@g-gaston g-gaston g-gaston approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@davidvossel davidvossel

@enxebre enxebre

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Add quickstart example in README
9 participants
@nunnatsa @davidvossel @enxebre @sbueringer @k8s-infra-cherrypick-robot @fabriziopandini @k8s-ci-robot @g-gaston @CecileRobertMichon