📖 Update Azure spot types to use string instead of float #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -214,7 +214,7 @@ when the instance is created: | |||
| (Delete is supported for VMs as part of VMSS only). | |||
|
|
|||
| - BillingProfile (default: -1) : This is a struct containing a single field, `MaxPrice`. | |||
| This is a float representation of the maximum price the user wishes to pay for their VM. | |||
| This is a string representation of the maximum price the user wishes to pay for their VM. | |||
There was a problem hiding this comment.
Can you please add a small comment about why we're using a string for the record? It might not be obvious to future readers.
vincepri
approved these changes
May 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b06ce0a to
dcfd137
Compare
|
@CecileRobertMichon I've added a link to a comment that I think will be helpful for future readers, do you think that's a good link to use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update the Spot instances proposal to clarify that the Azure types should use string instead of float as originally noted.
It was noticed during implementation (https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/559/files#r424579944) that floats are not allowed by the controller-tools crd generator tool
Ref: kubernetes-sigs/controller-tools#245
The alternative to this is to use a
resource.Quantitywhich is allowed, but I'm not sure if that adds much benefit over using a stringCC @CecileRobertMichon