Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update CAPO quick-start docs #11723

Merged
merged 1 commit into from
Jan 21, 2025
Merged

📖 Update CAPO quick-start docs #11723

merged 1 commit into from
Jan 21, 2025

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

Add information about dependence on ORC.
Fix whitespace.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation

@lentzi90
Update CAPO quick-start docs
27d1d48 
Add information about dependence on ORC.
Fix whitespace.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2025
@lentzi90
Copy link
Contributor Author

/cc @mdbooth @EmilienM
CAPO maintainers

@sbueringer
Copy link
Member

I'll take a look after an initial review from another CAPO maintainer

chrischdi
chrischdi reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@chrischdi
Copy link
Member

chrischdi commented Jan 21, 2025 •
edited
Loading

/hold for CAPO maintainer review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@chrischdi
Copy link
Member

/lgtm cancel
/hold cancel

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 21, 2025
@EmilienM
Copy link

Hi, CAPO maintainer here
/lgtm

Thanks @lentzi90!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2fdd57ad46eb974114ff159637ce30939deb5c94

@k8s-ci-robot k8s-ci-robot merged commit 7310d4b into kubernetes-sigs:main Jan 21, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jan 21, 2025
@chrischdi
Copy link
Member

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link

@chrischdi: new pull request created: #11724

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 21, 2025
Merged
@lentzi90 lentzi90 deleted the lentzi90/capo-docs branch January 21, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis

@JoelSpeed JoelSpeed

@EmilienM EmilienM

@mdbooth mdbooth

@chrischdi chrischdi

Assignees

@chrischdi chrischdi

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
6 participants
@lentzi90 @sbueringer @k8s-ci-robot @chrischdi @EmilienM @k8s-infra-cherrypick-robot