🌱Bump cert-manager to v1.15.0 #10727
Conversation
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-conformance-ci-latest-main |
a865360 to
3ba551f
Compare
| ms := ms | ||
|
|
There was a problem hiding this comment.
I don't believe we will backport this but if we do, this may need to be there if 1.7.x and 1.6.x use anything less than go1.22.
There was a problem hiding this comment.
This was done to pass the linting:
internal/controllers/machinedeployment/mdutil/util.go:433:3: The copy of the 'for' variable "ms" can be deleted (Go 1.22+) (copyloopvar)
There was a problem hiding this comment.
If there is a need to backport this, I can do this off the branch where it will not impact the linting rules at that branch go version (e.g. go1.21)
There was a problem hiding this comment.
I'm curious why this comes up at this (unrelated to this file) pull request 🤔
It should not be part of this PR.
There was a problem hiding this comment.
I'll open a PR to fix that separately.
There was a problem hiding this comment.
My concern with the removal of this to fix the linting, we will not have that loopvar in go1.21 & go1.20 (on the backports 1.6 & 1.7) where it may be necessary to have that within the scope of the loop (which 1.22 fixes).
Even rebasing with the xref #10731 will still carry that in to the older releases which may impact how that works. @chrischdi
There was a problem hiding this comment.
With merging #10731 and rebasing, this PR won't have the change to internal/controllers/machinedeployment/mdutil/util.go anymore and the cherry-picks should just go well. If there's still something missing then, then we have to do a manual cherry-pick I think.
There was a problem hiding this comment.
This has been rebased with main so I don't carry the linting change to the backports. Thanks @chrischdi
|
/cherry-pick release-1.7 |
|
@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.6 |
|
@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I can add it back but linting will fail, would the override be something we are willing to do? @chrischdi |
We should wait for #10731 to merge. |
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
3ba551f to
ea1dfcc
Compare
Merged and rebased with main to not carry the linting change in the backport. |
|
LGTM label has been added. Git tree hash: dcf92cff199eb44f4f9ec1a6d71e5758c4547d0e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-cluster-api-e2e-conformance-ci-latest-main just to make sure |
|
@troy0820: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@chrischdi: new pull request created: #10732 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@chrischdi: new pull request created: #10733 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Just fyi. I'm not concerned about having to do a manual cherry-pick (e.g. to not backport linter fixes) |
|
/lgtm (also double checked the release notes, all good) |
What this PR does / why we need it:
Updates cert-manager to v1.15.0
Which issue(s) this PR fixes: #10726
/area clusterctl