Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test that covers cluster health check behavior during creation of a new cluster accessor #8176

Closed
aljoshare opened this issue Feb 26, 2023 · 4 comments
Closed

Add unit test that covers cluster health check behavior during creation of a new cluster accessor #8176

aljoshare opened this issue Feb 26, 2023 · 4 comments
Labels
area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@aljoshare
Copy link
Contributor

After changing the behavior of the cluster health check when it gets executed during the creation of a new cluster accessor, a unit test that covers this case is needed. This issue is a follow-up task for #8122.

/kind cleanup
/area testing
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/testing Issues or PRs related to testing needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 26, 2023
@aljoshare
Copy link
Contributor Author

fyi @sbueringer

@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 27, 2023
@aljoshare aljoshare mentioned this issue Mar 12, 2023
Merged
@fabriziopandini
Copy link
Member

/close
given that #8269 is merged

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

/close
given that #8269 is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbueringer @fabriziopandini @aljoshare @k8s-ci-robot