Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCP: support pluggable proxy providers #3700

Closed
ncdc opened this issue Sep 25, 2020 · 15 comments
Closed

KCP: support pluggable proxy providers #3700

ncdc opened this issue Sep 25, 2020 · 15 comments
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@ncdc
Copy link
Contributor

ncdc commented Sep 25, 2020

User Story

As a user, I would like to create a new cluster using a proxy provider of my choosing, instead of having kubeadm install kube-proxy, because I'd like to use something other than kube-proxy from the start.

As a user, I would like to manage my proxy provider separately from KCP, decoupling their lifecycles, so that I'm in control of my proxy provider.

Detailed Description

See user stories

Anything else you would like to add:

kubeadm is currently responsible for installing kube-proxy and we'll need to be able to disable that.

/kind feature
/milestone Next

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the Next milestone Sep 25, 2020
@neolit123
Copy link
Member

neolit123 commented Sep 26, 2020

the current way is by passing --skip-phase=addons or a specific addons/x.
but i guess for CAPI this has to be supported via the config:
kubernetes/kubeadm#2261

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 25, 2020
@fabriziopandini
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 30, 2020
@vincepri
Copy link
Member

/assign @fabriziopandini
/milestone v1.1

@k8s-ci-robot k8s-ci-robot modified the milestones: Next, v1.1 Oct 29, 2021
@randomvariable
Copy link
Member

/area control-plane

@k8s-ci-robot k8s-ci-robot added the area/control-plane Issues or PRs related to control-plane lifecycle management label Nov 2, 2021
@vincepri
Copy link
Member

vincepri commented Nov 2, 2021

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 2, 2021
@fabriziopandini fabriziopandini modified the milestones: v1.1, v1.2 Feb 3, 2022
@fabriziopandini
Copy link
Member

/unassign

@fabriziopandini fabriziopandini added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini fabriziopandini removed this from the v1.2 milestone Jul 29, 2022
@fabriziopandini fabriziopandini removed the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini
Copy link
Member

/triage accepted

/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 30, 2022
@sbueringer
Copy link
Member

kubeadm is currently responsible for installing kube-proxy and we'll need to be able to disable that.

@fabriziopandini I think this is possible today via: controlplane.cluster.x-k8s.io/skip-kube-proxy

Not sure if this covers the entire issue.

@fabriziopandini
Copy link
Member

I have to dig into this, but on top of my mind what we have now isn't a clean API because you have to use phases to skip addon installation and then use the annotation above to avoid errors on upgrades.
But you are right, this can be achieved now; let's keep this open to see if we gather ideas about if and how we should improve the UX

@sbueringer
Copy link
Member

Oh you're right. Same for CoreDNS

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2024
@fabriziopandini
Copy link
Member

The Cluster API project currently lacks enough active contributors to adequately respond to all issues and PRs.

We already have skip-proxy annotation that allows to achieve something similar, but considering that there is no demand and the issue is not updated since 2022, I don't see this making progress anytime soon

/close

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

The Cluster API project currently lacks enough active contributors to adequately respond to all issues and PRs.

We already have skip-proxy annotation that allows to achieve something similar, but considering that there is no demand and the issue is not updated since 2022, I don't see this making progress anytime soon

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

9 participants