Skip to content

Commit

Permalink
Merge pull request #7581 from Prajyot-Parab/main
Browse files Browse the repository at this point in the history
✨ Introduce additional linters & bump golangci-lint to 1.50.1
  • Loading branch information
k8s-ci-robot authored Nov 22, 2022
2 parents 9a2f9b5 + 354d5b0 commit 844eff2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@0ad9a0988b3973e851ab0a07adf248ec2e100376 # tag=v3.3.1
with:
version: v1.50.0
version: v1.50.1
working-directory: ${{matrix.working-directory}}
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ linters:
- nilerr
- noctx
- nolintlint
- nosprintfhostport
- prealloc
- predeclared
- revive
Expand All @@ -52,6 +53,7 @@ linters:
- unconvert
- unparam
- unused
- usestdlibvars
- whitespace

linters-settings:
Expand Down
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/repository/goproxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (g *goproxyClient) getVersions(ctx context.Context, base, owner, repository
}
defer resp.Body.Close()

if resp.StatusCode != 200 {
if resp.StatusCode != http.StatusOK {
retryError = errors.Errorf("failed to get versions: response status code %d", resp.StatusCode)
return false, nil
}
Expand Down

0 comments on commit 844eff2

Please sign in to comment.