✨ Update kustomization.yaml to support kustomize v5 #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
==========================================
+ Coverage 63.68% 63.89% +0.21%
==========================================
Files 123 123
Lines 8767 8767
==========================================
+ Hits 5583 5602 +19
+ Misses 2764 2751 -13
+ Partials 420 414 -6 ☔ View full report in Codecov by Sentry. |
vincepri
approved these changes
Dec 1, 2023
|
/approve |
|
LGTM label has been added. Git tree hash: 8c5da0e9d55f15ae87766fbeb9f211ae23fb342e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the manifests kustomizations with kustomize v5 I'm getting the following error.
This is because kustomize v5.0 has dropped support for legacy patches.
kubernetes-sigs/kustomize#4911
kubernetes-sigs/kustomize#1373
As such the suggestion is to add the newly supported patches'
- path:syntax, which should be compatible as back as kustomize 3.0.1