Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup trivy for vulnerability scanning #1789

Closed
srm09 opened this issue Feb 17, 2023 · 7 comments
Closed

Setup trivy for vulnerability scanning #1789

srm09 opened this issue Feb 17, 2023 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@srm09
Copy link
Contributor

srm09 commented Feb 17, 2023

/kind feature

Describe the solution you'd like
CAPI has trivy to get an early signal on CVE vulnerabilities:
kubernetes-sigs/cluster-api#7604 related issue in the CAPI repo
kubernetes-sigs/cluster-api#7632 has links to other similar issues for some other providers

We should have a similar setup for CAPV PRs and make it not required, so even if it fails we could get the PR merged and open a follow up PR to remediate the issue.

Anything else you would like to add:
n/a

/priority important-soon
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 17, 2023
@srm09 srm09 added this to the v1.7.0 milestone Mar 3, 2023
@PatrickLaabs
Copy link
Contributor

Seems like CAPI and the AWS-Provider do run the scans with a cron defined in the GitHub action yaml.

I like the idea of having a scan on new releases as soon as the pr kicks off, and also on we weekly basis.
Maybe both ways are good to have?

Which images should be included from https://console.cloud.google.com/gcr/images/cluster-api-provider-vsphere ?
Only the ones inside the release-folder?

Best
Patrick

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Jun 12, 2023
@zhanggbj
Copy link
Contributor

Hey @srm09, is this still a valid issue, if it is true, I would like to work on it.

@killianmuldoon
Copy link
Contributor

@zhanggbj I think this should be done now and closed with a few PRs that merged yesterday - e.g. #1978, #1909, #1908.

We could close this now IMO.

@sbueringer
Copy link
Member

Yup looks good. @zhanggbj Sorry wasn't aware of this issue when we did the PRs.

I'll follow-up with some PRs to fix the found CVE's:

@sbueringer
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

7 participants