-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support cluster api v1alpha4 #334
Conversation
…er-ibmcloud into ibmvpccloud
…provider-ibmcloud into ibmvpccloud
fix: typo: ibmachine should be ibmmachines
…ibmcloud into ibmcloud
@wentao-zh: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @wentao-zh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wentao-zh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wentao-zh ibmcloud branch is not maintained anymore, can you please submit changes to |
@mkumatag Then main branch is based on vpc implementaion. My PR is based on generic ibmcloud implementation. So we need to discuss about how can it be merged. |
What this PR does / why we need it:
This PR makes provider supports clulster-api v1alpha4
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Specify your PR reviewers:
/cc @gyliu513 @jichenjc @xunpan
Special notes for your reviewer:
/area provider/ibmcloud
Release note: