v1alpha4 support

[mkumatag]

What this PR does / why we need it:

v1alpha4 support

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @jichenjc @wentao-zh

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

v1alpha4 support

[k8s-ci-robot]

@mkumatag: GitHub didn't allow me to request PR reviews from the following users: wentao-zh.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

v1alpha4 support

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @jichenjc @wentao-zh

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

v1alpha4 support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gyliu513]

Thanks @mkumatag , looks great and just one minor comment want to get your conform for RBAC.

[mkumatag]

/hold for further testing

[gyliu513]

/lgtm

Thanks @mkumatag , looks good to me.

@wentao-zh can you help get someone to do some test against this new PR?

[wentao-zh]

/lgtm

Thanks @mkumatag , looks good to me.

@wentao-zh can you help get someone to do some test against this new PR?

Yes. I'm working on this testing right now.

[wentao-zh]

/lgtm

Thanks @mkumatag , looks good to me.

@wentao-zh can you help get someone to do some test against this new PR?

I've tested this branch and it works.
Note: only version above v0.4.0 of cluster api can support v1alpha4.

[mkumatag]

/lgtm
Thanks @mkumatag , looks good to me.
@wentao-zh can you help get someone to do some test against this new PR?

I've tested this branch and it works.
Note: only version above v0.4.0 of cluster api can support v1alpha4.

true that, even we might need to think about cutting a branch with 0.3.x for v1alpha3 support and a main branch for alpha4

[gyliu513]

@wentao-zh @mkumatag since cluster api has some break changes between different versions as it is still involving fast, can we merge this PR? I think we do not need to support cluster api 0.3.0 as long as the current branch works after the PR got merged, comments?

[mkumatag]

@wentao-zh @mkumatag since cluster api has some break changes between different versions as it is still involving fast, can we merge this PR? I think we do not need to support cluster api 0.3.0 as long as the current branch works after the PR got merged, comments?

agree,!

[jichenjc]

+1 , unless it become better, the API will change very fast, if we really need think about some kind of alpah3 to alpha4, maybe can refer to
https://cluster-api.sigs.k8s.io/developer/providers/v1alpha3-to-v1alpha4.html
but guess not necessary

[mkumatag]

+1 , unless it become better, the API will change very fast, if we really need think about some kind of alpah3 to alpha4, maybe can refer to
https://cluster-api.sigs.k8s.io/developer/providers/v1alpha3-to-v1alpha4.html
but guess not necessary

I have used this guide and adopted the recommendation wherever necessary,

[gyliu513]

/unhold
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gyliu513]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment