Update cluster-api to v1.8.1 #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/hold |
|
@Amulyam24 once you get sometime, Please help in fixing the test failures, We will try to get necessary things done by next week. |
|
@Amulyam24 need to probably also update - https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/3b2125731bb9b77021128f222b165e53f853e6dd/cloudbuild.yaml#L7C5-L7C81 |
2f3c204 to
5d0db1f
Compare
|
but I think rc is already released! |
4387238 to
7d07f20
Compare
fe8f19e to
5fac05f
Compare
|
/hold cancel PR is ready for review, PTAL! |
|
/hold |
a60c08d to
7d72955
Compare
|
/hold cancel |
|
@mkumatag @Prajyot-Parab PTAL, PR is ready for review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates
generate-go-conversionsin Makefile where deprecated flags have been removed/modified afterconversion-genversion update to v0.30.3Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1884
Special notes for your reviewer:
/area provider/ibmcloud
Release note: