Refactor logging

[Amulyam24]

What this PR does / why we need it:

This PR adds

• Logs wherever necessary
• Proper naming for PowerVS and VPC
• Consistent error format starting with failed to
• Add appropriate log levels, debug set at level 3
• Consistent naming of infra resources

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1720

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Refactor logging

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	27f93eb
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/664dbb1aa7854100089301b7
😎 Deploy Preview	https://deploy-preview-1755--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Prajyot-Parab]

/cc @Karthik-K-N

[Karthik-K-N]

This is one of the much needed PR, Thanks for submitting this.

/lgtm

[Amulyam24]

/hold

[Prajyot-Parab]

/remove-approve

[Amulyam24]

@Karthik-K-N @Prajyot-Parab , what are your thoughts on changing the log level to 3 by default?
By default if user doesn't set v flag, we will be missing important log messages with the current changes right?

[Karthik-K-N]

@Karthik-K-N @Prajyot-Parab , what are your thoughts on changing the log level to 3 by default? By default if user doesn't set v flag, we will be missing important log messages with the current changes right?

If we go as per capi standards the logs are not for users its for sre/developers https://cluster-api.sigs.k8s.io/developer/logging#logging.
So we can keep info/generic logs at level 1, debug information at 3 and more detailed info around 5 v levels.

So we can update the doc in developer section of the book about setting v level to higher one if the user is interested in debugging things.

Meanwhile we should spend some time in adding more events and condition with user perspective in mind.

[Amulyam24]

@Karthik-K-N @Prajyot-Parab , what are your thoughts on changing the log level to 3 by default? By default if user doesn't set v flag, we will be missing important log messages with the current changes right?

If we go as per capi standards the logs are not for users its for sre/developers https://cluster-api.sigs.k8s.io/developer/logging#logging. So we can keep info/generic logs at level 1, debug information at 3 and more detailed info around 5 v levels.

So we can update the doc in developer section of the book about setting v level to higher one if the user is interested in debugging things.

Meanwhile we should spend some time in adding more events and condition with user perspective in mind.

Thank you for the input @Karthik-K-N, will refactor the logs accordingly.

[dharaneeshvrd]

@Amulyam24 errors appended during reconcileDelete are not printed in controller log, there is no way to know it as well, please see whether we can add a log message here

[mkumatag]

@Amulyam24 can you please resolve the conflicts and update the PR?

[mkumatag]

/unhold

[Amulyam24]

@Amulyam24 can you please resolve the conflicts and update the PR?

PR is ready for review, PTAL @mkumatag @Karthik-K-N

[Karthik-K-N]

/lgtm

[mkumatag]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment