Scale from and to 0 support for autoscaler for VPC cluster #1523

KeerthanaAP · 2023-12-01T05:56:50Z

What this PR does / why we need it:

This PR add the chances to scale from and to 0 support for autoscaler for VPC cluster.
Added a IBMVPCMachineTemplateStatus with capacity field and a separate controller to update the capacity.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #959

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Scale from and to 0 support for autoscaler for VPC cluster

Complete integration testing
Add Unit tests
Update doc

netlify · 2023-12-01T05:56:56Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`6606eb8`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/65c4a218e61c2c000731fe5f
😎 Deploy Preview	https://deploy-preview-1523--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot · 2023-12-01T05:57:00Z

Hi @KeerthanaAP. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Prajyot-Parab · 2023-12-01T07:01:20Z

/cc @Karthik-K-N

Prajyot-Parab · 2023-12-01T07:01:34Z

/ok-to-test

api/v1beta1/ibmvpcmachinetemplate_types.go

Prajyot-Parab · 2023-12-04T10:37:51Z

controllers/ibmvpcmachinetemplate_controller_test.go

+			capacity, err := getIBMVPCMachineCapacity(tc.VPCMachineTemplate)
+			if tc.expectErr {
+				if err == nil {
+					t.Fatal("getIBMPowerVSMachineCapacity expected to return an error")


Suggested change

t.Fatal("getIBMPowerVSMachineCapacity expected to return an error")

t.Fatal("getIBMVPCMachineCapacity expected to return an error")

controllers/ibmvpcmachinetemplate_controller_test.go

Prajyot-Parab · 2023-12-04T10:42:58Z

@KeerthanaAP Do a sample deployment of above logic
attach the v1beta2 -> v1beta1 converted resource version of deployment
repeat for v1beta1 -> v1beta2 and v1beta2 -> v1beta1 -> v1beta2

/cc @Karthik-K-N

Prajyot-Parab · 2023-12-04T10:55:02Z

What this PR does / why we need it:

This PR add the chances to scale from and to 0 support for autoscaler for VPC cluster. Added a IBMVPCMachineTemplateStatus with capacity field and a separate controller to update the capacity.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #959

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:
Complete integration testing

Add Unit tests

Update doc

@KeerthanaAP Update Release note section

Karthik-K-N · 2023-12-12T04:24:21Z

controllers/ibmvpcmachinetemplate_controller.go

+
+func (r *IBMVPCMachineTemplateReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
+	log := ctrl.LoggerFrom(ctx)
+	log.V(1).Info("Reconciling IBMVPCMachineTemplate")


May I know whats the default log level? can this be simply log.Info().

I think default log level is 1.
Have changed it to log.Info().

controllers/ibmvpcmachinetemplate_controller.go

Karthik-K-N

One change otherwise LGTM

controllers/ibmvpcmachinetemplate_controller.go

KeerthanaAP · 2023-12-14T09:40:43Z

@KeerthanaAP Do a sample deployment of above logic attach the v1beta2 -> v1beta1 converted resource version of deployment repeat for v1beta1 -> v1beta2 and v1beta2 -> v1beta1 -> v1beta2

/cc @Karthik-K-N

Deployment v1beta2 -> v1beta1

v1beta2

$kubectl get ibmvpcmachinetemplates.v1beta2.infrastructure.cluster.x-k8s.io -o yaml
apiVersion: v1
items:
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
  kind: IBMVPCMachineTemplate
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"name":"ibm-vpc-2-control-plane","namespace":"default"},"spec":{"template":{"spec":{"bootVolume":{"sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}}}
    creationTimestamp: "2023-12-14T07:31:44Z"
    generation: 1
    name: ibm-vpc-2-control-plane
    namespace: default
    ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      kind: Cluster
      name: ibm-vpc-2
      uid: b04c0668-5865-42c0-b245-b7e98647c199
    resourceVersion: "44245"
    uid: d7b7da31-a9d0-4701-a348-2a4dbbd90a30
  spec:
    template:
      spec:
        bootVolume:
          deleteVolumeOnInstanceDelete: true
          profile: general-purpose
          sizeGiB: 20
        image:
          name: capibm-vpc-ubuntu-2004-kube-v1-27-2
        primaryNetworkInterface: {}
        profile: bx2-4x16
        sshKeys:
        - name: keerthana-ssh
        zone: au-syd-1
  status:
    capacity:
      cpu: "4"
      memory: 16G
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
  kind: IBMVPCMachineTemplate
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"name":"ibm-vpc-2-md-0","namespace":"default"},"spec":{"template":{"spec":{"bootVolume":{"sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}}}
    creationTimestamp: "2023-12-14T07:31:46Z"
    generation: 1
    name: ibm-vpc-2-md-0
    namespace: default
    ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      kind: Cluster
      name: ibm-vpc-2
      uid: b04c0668-5865-42c0-b245-b7e98647c199
    resourceVersion: "44146"
    uid: 7a2c7e5b-a8e2-40a8-9901-3a81c064c7d6
  spec:
    template:
      spec:
        bootVolume:
          deleteVolumeOnInstanceDelete: true
          profile: general-purpose
          sizeGiB: 20
        image:
          name: capibm-vpc-ubuntu-2004-kube-v1-27-2
        primaryNetworkInterface: {}
        profile: bx2-4x16
        sshKeys:
        - name: keerthana-ssh
        zone: au-syd-1
  status:
    capacity:
      cpu: "4"
      memory: 16G
kind: List
metadata:
  resourceVersion: ""


v1beta1 

$kubectl get ibmvpcmachinetemplates.v1beta1.infrastructure.cluster.x-k8s.io -o yaml
apiVersion: v1
items:
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: IBMVPCMachineTemplate
  metadata:
    annotations:
      cluster.x-k8s.io/conversion-data: '{"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}},"status":{"capacity":{"cpu":"4","memory":"16G"}}}'
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"name":"ibm-vpc-2-control-plane","namespace":"default"},"spec":{"template":{"spec":{"bootVolume":{"sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}}}
    creationTimestamp: "2023-12-14T07:31:44Z"
    generation: 1
    name: ibm-vpc-2-control-plane
    namespace: default
    ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      kind: Cluster
      name: ibm-vpc-2
      uid: b04c0668-5865-42c0-b245-b7e98647c199
    resourceVersion: "44245"
    uid: d7b7da31-a9d0-4701-a348-2a4dbbd90a30
  spec:
    template:
      spec:
        bootVolume:
          deleteVolumeOnInstanceDelete: true
          profile: general-purpose
          sizeGiB: 20
        imageName: capibm-vpc-ubuntu-2004-kube-v1-27-2
        primaryNetworkInterface: {}
        profile: bx2-4x16
        sshKeyNames:
        - keerthana-ssh
        zone: au-syd-1
  status: {}
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: IBMVPCMachineTemplate
  metadata:
    annotations:
      cluster.x-k8s.io/conversion-data: '{"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}},"status":{"capacity":{"cpu":"4","memory":"16G"}}}'
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"name":"ibm-vpc-2-md-0","namespace":"default"},"spec":{"template":{"spec":{"bootVolume":{"sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}}}
    creationTimestamp: "2023-12-14T07:31:46Z"
    generation: 1
    name: ibm-vpc-2-md-0
    namespace: default
    ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      kind: Cluster
      name: ibm-vpc-2
      uid: b04c0668-5865-42c0-b245-b7e98647c199
    resourceVersion: "44146"
    uid: 7a2c7e5b-a8e2-40a8-9901-3a81c064c7d6
  spec:
    template:
      spec:
        bootVolume:
          deleteVolumeOnInstanceDelete: true
          profile: general-purpose
          sizeGiB: 20
        imageName: capibm-vpc-ubuntu-2004-kube-v1-27-2
        primaryNetworkInterface: {}
        profile: bx2-4x16
        sshKeyNames:
        - keerthana-ssh
        zone: au-syd-1
  status: {}
kind: List
metadata:
  resourceVersion: ""

Deployment v1beta1 -> v1beta2

Deployed the below v1beta1 config. Created this v1beta1 config after removing the annotation in above v1beta1

v1beta1.yaml

apiVersion: v1
items:
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: IBMVPCMachineTemplate
  metadata:
    creationTimestamp: "2023-12-14T07:31:44Z"
    generation: 1
    name: ibm-vpc-2-control-plane
    namespace: default
    ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      kind: Cluster
      name: ibm-vpc-2
      uid: b04c0668-5865-42c0-b245-b7e98647c199
    resourceVersion: "44245"
    uid: d7b7da31-a9d0-4701-a348-2a4dbbd90a30
  spec:
    template:
      spec:
        bootVolume:
          deleteVolumeOnInstanceDelete: true
          profile: general-purpose
          sizeGiB: 20
        imageName: capibm-vpc-ubuntu-2004-kube-v1-27-2
        primaryNetworkInterface: {}
        profile: bx2-4x16
        sshKeyNames:
        - keerthana-ssh
        zone: au-syd-1
  status: {}
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: IBMVPCMachineTemplate
  metadata:
    creationTimestamp: "2023-12-14T07:31:46Z"
    generation: 1
    name: ibm-vpc-2-md-0
    namespace: default
    ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      kind: Cluster
      name: ibm-vpc-2
      uid: b04c0668-5865-42c0-b245-b7e98647c199
    resourceVersion: "44146"
    uid: 7a2c7e5b-a8e2-40a8-9901-3a81c064c7d6
  spec:
    template:
      spec:
        bootVolume:
          deleteVolumeOnInstanceDelete: true
          profile: general-purpose
          sizeGiB: 20
        imageName: capibm-vpc-ubuntu-2004-kube-v1-27-2
        primaryNetworkInterface: {}
        profile: bx2-4x16
        sshKeyNames:
        - keerthana-ssh
        zone: au-syd-1
  status: {}
kind: List
metadata:
  resourceVersion: ""

v1beta1:
 
$kubectl get ibmvpcmachinetemplates.v1beta1.infrastructure.cluster.x-k8s.io -o yaml
apiVersion: v1
items:
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
 kind: IBMVPCMachineTemplate
 metadata:
   annotations:
     cluster.x-k8s.io/conversion-data: '{"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}},"status":{"capacity":{"cpu":"4","memory":"16G"}}}'
     kubectl.kubernetes.io/last-applied-configuration: |
       {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"creationTimestamp":"2023-12-14T07:31:44Z","generation":1,"name":"ibm-vpc-2-control-plane","namespace":"default","ownerReferences":[{"apiVersion":"cluster.x-k8s.io/v1beta1","kind":"Cluster","name":"ibm-vpc-2","uid":"b04c0668-5865-42c0-b245-b7e98647c199"}],"resourceVersion":"44245","uid":"d7b7da31-a9d0-4701-a348-2a4dbbd90a30"},"spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"imageName":"capibm-vpc-ubuntu-2004-kube-v1-27-2","primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeyNames":["keerthana-ssh"],"zone":"au-syd-1"}}},"status":{}}
   creationTimestamp: "2023-12-14T09:25:56Z"
   generation: 1
   name: ibm-vpc-2-control-plane
   namespace: default
   ownerReferences:
   - apiVersion: cluster.x-k8s.io/v1beta1
     kind: Cluster
     name: ibm-vpc-2
     uid: b04c0668-5865-42c0-b245-b7e98647c199
   resourceVersion: "56940"
   uid: dbdd6947-f5be-4276-a8a6-e49bd0553178
 spec:
   template:
     spec:
       bootVolume:
         deleteVolumeOnInstanceDelete: true
         profile: general-purpose
         sizeGiB: 20
       imageName: capibm-vpc-ubuntu-2004-kube-v1-27-2
       primaryNetworkInterface: {}
       profile: bx2-4x16
       sshKeyNames:
       - keerthana-ssh
       zone: au-syd-1
 status: {}
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
 kind: IBMVPCMachineTemplate
 metadata:
   annotations:
     cluster.x-k8s.io/conversion-data: '{"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}},"status":{"capacity":{"cpu":"4","memory":"16G"}}}'
     kubectl.kubernetes.io/last-applied-configuration: |
       {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"creationTimestamp":"2023-12-14T07:31:46Z","generation":1,"name":"ibm-vpc-2-md-0","namespace":"default","ownerReferences":[{"apiVersion":"cluster.x-k8s.io/v1beta1","kind":"Cluster","name":"ibm-vpc-2","uid":"b04c0668-5865-42c0-b245-b7e98647c199"}],"resourceVersion":"44146","uid":"7a2c7e5b-a8e2-40a8-9901-3a81c064c7d6"},"spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"imageName":"capibm-vpc-ubuntu-2004-kube-v1-27-2","primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeyNames":["keerthana-ssh"],"zone":"au-syd-1"}}},"status":{}}
   creationTimestamp: "2023-12-14T09:25:59Z"
   generation: 1
   name: ibm-vpc-2-md-0
   namespace: default
   ownerReferences:
   - apiVersion: cluster.x-k8s.io/v1beta1
     kind: Cluster
     name: ibm-vpc-2
     uid: b04c0668-5865-42c0-b245-b7e98647c199
   resourceVersion: "56952"
   uid: be4b0089-d8a8-46c9-a80a-dafa7cb3e369
 spec:
   template:
     spec:
       bootVolume:
         deleteVolumeOnInstanceDelete: true
         profile: general-purpose
         sizeGiB: 20
       imageName: capibm-vpc-ubuntu-2004-kube-v1-27-2
       primaryNetworkInterface: {}
       profile: bx2-4x16
       sshKeyNames:
       - keerthana-ssh
       zone: au-syd-1
 status: {}
kind: List
metadata:
 resourceVersion: ""


v1beta2:

$kubectl get ibmvpcmachinetemplates.v1beta2.infrastructure.cluster.x-k8s.io -o yaml
apiVersion: v1
items:
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
 kind: IBMVPCMachineTemplate
 metadata:
   annotations:
     cluster.x-k8s.io/conversion-data: '{"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}},"status":{}}'
     kubectl.kubernetes.io/last-applied-configuration: |
       {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"creationTimestamp":"2023-12-14T07:31:44Z","generation":1,"name":"ibm-vpc-2-control-plane","namespace":"default","ownerReferences":[{"apiVersion":"cluster.x-k8s.io/v1beta1","kind":"Cluster","name":"ibm-vpc-2","uid":"b04c0668-5865-42c0-b245-b7e98647c199"}],"resourceVersion":"44245","uid":"d7b7da31-a9d0-4701-a348-2a4dbbd90a30"},"spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"imageName":"capibm-vpc-ubuntu-2004-kube-v1-27-2","primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeyNames":["keerthana-ssh"],"zone":"au-syd-1"}}},"status":{}}
   creationTimestamp: "2023-12-14T09:25:56Z"
   generation: 1
   name: ibm-vpc-2-control-plane
   namespace: default
   ownerReferences:
   - apiVersion: cluster.x-k8s.io/v1beta1
     kind: Cluster
     name: ibm-vpc-2
     uid: b04c0668-5865-42c0-b245-b7e98647c199
   resourceVersion: "56940"
   uid: dbdd6947-f5be-4276-a8a6-e49bd0553178
 spec:
   template:
     spec:
       bootVolume:
         deleteVolumeOnInstanceDelete: true
         profile: general-purpose
         sizeGiB: 20
       image:
         name: capibm-vpc-ubuntu-2004-kube-v1-27-2
       primaryNetworkInterface: {}
       profile: bx2-4x16
       sshKeys:
       - name: keerthana-ssh
       zone: au-syd-1
 status:
   capacity:
     cpu: "4"
     memory: 16G
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
 kind: IBMVPCMachineTemplate
 metadata:
   annotations:
     cluster.x-k8s.io/conversion-data: '{"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta2","kind":"IBMVPCMachineTemplate","spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"image":{"name":"capibm-vpc-ubuntu-2004-kube-v1-27-2"},"primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeys":[{"name":"keerthana-ssh"}],"zone":"au-syd-1"}}},"status":{}}'
     kubectl.kubernetes.io/last-applied-configuration: |
       {"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","kind":"IBMVPCMachineTemplate","metadata":{"annotations":{},"creationTimestamp":"2023-12-14T07:31:46Z","generation":1,"name":"ibm-vpc-2-md-0","namespace":"default","ownerReferences":[{"apiVersion":"cluster.x-k8s.io/v1beta1","kind":"Cluster","name":"ibm-vpc-2","uid":"b04c0668-5865-42c0-b245-b7e98647c199"}],"resourceVersion":"44146","uid":"7a2c7e5b-a8e2-40a8-9901-3a81c064c7d6"},"spec":{"template":{"spec":{"bootVolume":{"deleteVolumeOnInstanceDelete":true,"profile":"general-purpose","sizeGiB":20},"imageName":"capibm-vpc-ubuntu-2004-kube-v1-27-2","primaryNetworkInterface":{},"profile":"bx2-4x16","sshKeyNames":["keerthana-ssh"],"zone":"au-syd-1"}}},"status":{}}
   creationTimestamp: "2023-12-14T09:25:59Z"
   generation: 1
   name: ibm-vpc-2-md-0
   namespace: default
   ownerReferences:
   - apiVersion: cluster.x-k8s.io/v1beta1
     kind: Cluster
     name: ibm-vpc-2
     uid: b04c0668-5865-42c0-b245-b7e98647c199
   resourceVersion: "56952"
   uid: be4b0089-d8a8-46c9-a80a-dafa7cb3e369
 spec:
   template:
     spec:
       bootVolume:
         deleteVolumeOnInstanceDelete: true
         profile: general-purpose
         sizeGiB: 20
       image:
         name: capibm-vpc-ubuntu-2004-kube-v1-27-2
       primaryNetworkInterface: {}
       profile: bx2-4x16
       sshKeys:
       - name: keerthana-ssh
       zone: au-syd-1
 status:
   capacity:
     cpu: "4"
     memory: 16G
kind: List
metadata:
 resourceVersion: ""

Prajyot-Parab · 2023-12-15T04:23:03Z

/retest all

k8s-ci-robot · 2023-12-15T04:23:06Z

@Prajyot-Parab: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-ccm-image
/test pull-cluster-api-provider-ibmcloud-build
/test pull-cluster-api-provider-ibmcloud-coverage
/test pull-cluster-api-provider-ibmcloud-make
/test pull-cluster-api-provider-ibmcloud-smoke-test
/test pull-cluster-api-provider-ibmcloud-test
/test pull-cluster-api-provider-ibmcloud-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-ibmcloud-apidiff

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-ibmcloud-apidiff
pull-cluster-api-provider-ibmcloud-build
pull-cluster-api-provider-ibmcloud-coverage
pull-cluster-api-provider-ibmcloud-make
pull-cluster-api-provider-ibmcloud-smoke-test
pull-cluster-api-provider-ibmcloud-test
pull-cluster-api-provider-ibmcloud-verify

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Prajyot-Parab · 2023-12-15T04:23:30Z

/test all

Prajyot-Parab · 2023-12-15T05:36:18Z

/cc @Karthik-K-N ptal final look.

Karthik-K-N

/lgtm

KeerthanaAP · 2024-02-06T05:33:50Z

/retest

KeerthanaAP · 2024-02-06T07:45:27Z

/retest

KeerthanaAP · 2024-02-06T08:07:43Z

/retest-required

controllers/ibmvpcmachinetemplate_controller_test.go

controllers/ibmvpcmachinetemplate_controller.go

KeerthanaAP · 2024-02-07T04:51:54Z

/retest

controllers/ibmvpcmachinetemplate_controller_test.go

controllers/ibmvpcmachinetemplate_controller.go

Karthik-K-N

Thank you, One small change, Otherwise LGTM

controllers/ibmvpcmachinetemplate_controller.go

Karthik-K-N

/lgtm

mkumatag

/hold

for @Prajyot-Parab 's review

Prajyot-Parab

/lgtm

k8s-ci-robot · 2024-02-09T09:06:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, KeerthanaAP, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Prajyot-Parab · 2024-02-09T09:06:12Z

/unhold

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Dec 1, 2023

k8s-ci-robot requested review from Prajyot-Parab and relyt0925 December 1, 2023 05:56

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2023

k8s-ci-robot requested a review from Karthik-K-N December 1, 2023 07:01

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2023

Prajyot-Parab suggested changes Dec 4, 2023

View reviewed changes

Karthik-K-N reviewed Dec 12, 2023

View reviewed changes

KeerthanaAP force-pushed the VPC_Autoscaler branch 2 times, most recently from 5175b06 to 4f3dd0e Compare December 13, 2023 14:50

Karthik-K-N reviewed Dec 13, 2023

View reviewed changes

controllers/ibmvpcmachinetemplate_controller.go Outdated Show resolved Hide resolved

KeerthanaAP force-pushed the VPC_Autoscaler branch from 4f3dd0e to 6776eb5 Compare December 14, 2023 09:46

Karthik-K-N approved these changes Jan 16, 2024

View reviewed changes

k8s-ci-robot assigned Karthik-K-N Jan 16, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024

KeerthanaAP force-pushed the VPC_Autoscaler branch from edb4515 to fda3f59 Compare February 5, 2024 13:05

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 5, 2024

KeerthanaAP force-pushed the VPC_Autoscaler branch from fda3f59 to d49f29b Compare February 6, 2024 06:07

KeerthanaAP force-pushed the VPC_Autoscaler branch from d49f29b to fbc8ab0 Compare February 6, 2024 08:46

Karthik-K-N reviewed Feb 6, 2024

View reviewed changes

controllers/ibmvpcmachinetemplate_controller_test.go Outdated Show resolved Hide resolved

controllers/ibmvpcmachinetemplate_controller.go Show resolved Hide resolved

controllers/ibmvpcmachinetemplate_controller.go Outdated Show resolved Hide resolved

KeerthanaAP force-pushed the VPC_Autoscaler branch from fbc8ab0 to 6910468 Compare February 7, 2024 05:18

Karthik-K-N reviewed Feb 7, 2024

View reviewed changes

KeerthanaAP force-pushed the VPC_Autoscaler branch 2 times, most recently from d9f6594 to 0912a42 Compare February 7, 2024 08:24

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2024

Karthik-K-N reviewed Feb 8, 2024

View reviewed changes

controllers/ibmvpcmachinetemplate_controller.go Outdated Show resolved Hide resolved

Removed duplicate and updated error message

6606eb8

KeerthanaAP force-pushed the VPC_Autoscaler branch from 0912a42 to 6606eb8 Compare February 8, 2024 09:42

Karthik-K-N reviewed Feb 9, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024

mkumatag approved these changes Feb 9, 2024

View reviewed changes

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2024

Prajyot-Parab approved these changes Feb 9, 2024

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024

k8s-ci-robot merged commit 7150fb8 into kubernetes-sigs:main Feb 9, 2024
13 checks passed

KeerthanaAP deleted the VPC_Autoscaler branch April 4, 2024 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scale from and to 0 support for autoscaler for VPC cluster #1523

Scale from and to 0 support for autoscaler for VPC cluster #1523

KeerthanaAP commented Dec 1, 2023 •

edited

Loading

netlify bot commented Dec 1, 2023 •

edited

Loading

k8s-ci-robot commented Dec 1, 2023

Prajyot-Parab commented Dec 1, 2023

Prajyot-Parab commented Dec 1, 2023

Prajyot-Parab Dec 4, 2023

KeerthanaAP Dec 6, 2023

Prajyot-Parab commented Dec 4, 2023

Prajyot-Parab commented Dec 4, 2023

Karthik-K-N Dec 12, 2023

KeerthanaAP Dec 13, 2023

Karthik-K-N left a comment

KeerthanaAP commented Dec 14, 2023

Prajyot-Parab commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

Prajyot-Parab commented Dec 15, 2023

Prajyot-Parab commented Dec 15, 2023

Karthik-K-N left a comment

KeerthanaAP commented Feb 6, 2024

KeerthanaAP commented Feb 6, 2024

KeerthanaAP commented Feb 6, 2024

KeerthanaAP commented Feb 7, 2024

Karthik-K-N left a comment

Karthik-K-N left a comment

mkumatag left a comment

Prajyot-Parab left a comment

k8s-ci-robot commented Feb 9, 2024

Prajyot-Parab commented Feb 9, 2024

	t.Fatal("getIBMPowerVSMachineCapacity expected to return an error")
	t.Fatal("getIBMVPCMachineCapacity expected to return an error")

Scale from and to 0 support for autoscaler for VPC cluster #1523

Scale from and to 0 support for autoscaler for VPC cluster #1523

Conversation

KeerthanaAP commented Dec 1, 2023 • edited Loading

netlify bot commented Dec 1, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

k8s-ci-robot commented Dec 1, 2023

Prajyot-Parab commented Dec 1, 2023

Prajyot-Parab commented Dec 1, 2023

Prajyot-Parab Dec 4, 2023

Choose a reason for hiding this comment

KeerthanaAP Dec 6, 2023

Choose a reason for hiding this comment

Prajyot-Parab commented Dec 4, 2023

Prajyot-Parab commented Dec 4, 2023

Karthik-K-N Dec 12, 2023

Choose a reason for hiding this comment

KeerthanaAP Dec 13, 2023

Choose a reason for hiding this comment

Karthik-K-N left a comment

Choose a reason for hiding this comment

KeerthanaAP commented Dec 14, 2023

Prajyot-Parab commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

Prajyot-Parab commented Dec 15, 2023

Prajyot-Parab commented Dec 15, 2023

Karthik-K-N left a comment

Choose a reason for hiding this comment

KeerthanaAP commented Feb 6, 2024

KeerthanaAP commented Feb 6, 2024

KeerthanaAP commented Feb 6, 2024

KeerthanaAP commented Feb 7, 2024

Karthik-K-N left a comment

Choose a reason for hiding this comment

Karthik-K-N left a comment

Choose a reason for hiding this comment

mkumatag left a comment

Choose a reason for hiding this comment

Prajyot-Parab left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 9, 2024

Prajyot-Parab commented Feb 9, 2024

KeerthanaAP commented Dec 1, 2023 •

edited

Loading

netlify bot commented Dec 1, 2023 •

edited

Loading