Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROVIDER_ID_FORMAT references replacement. #1473

Merged
merged 2 commits into from
Nov 6, 2023
Merged

PROVIDER_ID_FORMAT references replacement. #1473

merged 2 commits into from
Nov 6, 2023

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented Nov 2, 2023

What this PR does / why we need it:
This PR contains the changes to point to the correct usage of PROVIDER_ID_FORMAT in the .md files of the CAPI book, updated references to keep documents inline with the intended usage.

Also contains a change in table's format and alignment, to adapt to a smaller space.

Which issue(s) this PR fixes
Fixes #1471

Special notes for your reviewer:

/area provider/ibmcloud

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 2, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 2cc9033
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6548749704a4680008721058
😎 Deploy Preview https://deploy-preview-1473--kubernetes-sigs-cluster-api-ibmcloud.netlify.app/print
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kishen-v. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2023
@Prajyot-Parab
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2023
mkumatag
mkumatag requested changes Nov 3, 2023
View reviewed changes
README.md Outdated
| IBMCloud Provider v1beta2 (v0.4.x, v0.5.x, v0.6.x, main) | | ✓ |
| |Cluster API v1alpha4 (v0.4) |Cluster API v1beta1 (v1.x) |
|:----------------------------------------|:---------------:|:--------------:|
| CAPI v1alpha4 (v0.1.x) | ✓ | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this CAPI? this is suppose to be CAPIBM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkumatag, I have made the required changes.
Thanks!

@kishen-v kishen-v force-pushed the fix-1471-refs-replacement branch 2 times, most recently from 4490e90 to 70caa50 Compare November 6, 2023 04:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2023
Karthik-K-N
Karthik-K-N reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets validate links otherwise looks good to me.

docs/book/src/topics/powervs/external-cloud-provider.md Outdated
@@ -5,7 +5,7 @@

- To deploy a PowerVS workload cluster with IBM PowerVS external [cloud provider](https://kubernetes.io/docs/concepts/architecture/cloud-controller/), create a cluster configuration with the [external cloud provider template](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/templates/cluster-template-powervs-cloud-provider.yaml)
- The [external cloud provider template](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/templates/cluster-template-powervs-cloud-provider.yaml) will use [clusterresourceset](https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-resource-set.html) and will create the necessary config map, secret and roles to run the cloud controller manager
- As a prerequisite set the `powervs-provider-id-fmt` [flag](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/64c9e1d17f1733c721f45a559edba3f4b712bcb0/main.go#L220) with value v2
- As a prerequisite set the `provider-id-fmt` [flag](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/64c9e1d17f1733c721f45a559edba3f4b712bcb0/main.go#L220) with value v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we need to update the link as well.

cluster-api-provider-ibmcloud/main.go

Line 220 in 64c9e1d

fs.StringVar(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates with the changes from the latest code. Thank you. :)

@kishen-v kishen-v force-pushed the fix-1471-refs-replacement branch from 70caa50 to 2cc9033 Compare November 6, 2023 05:07
mkumatag
mkumatag approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

for @Karthik-K-N to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@Karthik-K-N
Copy link
Contributor

/lgtm

@Karthik-K-N
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 29fe21c into kubernetes-sigs:main Nov 6, 2023
3 checks passed
@kishen-v kishen-v deleted the fix-1471-refs-replacement branch November 21, 2023 10:08
@kishen-v kishen-v mentioned this pull request Jan 18, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@mkumatag mkumatag mkumatag approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@relyt0925 relyt0925 Awaiting requested review from relyt0925

Assignees

@mkumatag mkumatag

@Karthik-K-N Karthik-K-N

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace reference of POWERVS_PROVIDER_ID_FORMAT with PROVIDER_ID_FORMAT
5 participants
@kishen-v @k8s-ci-robot @Prajyot-Parab @Karthik-K-N @mkumatag