Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code for VPC FIP #1395

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove code for VPC FIP #1395

merged 1 commit into from
Oct 30, 2023

Conversation

Prajyot-Parab
Copy link
Contributor

What this PR does / why we need it:

  • Remove code for VPC FIP
  • Rename cluster-template-vpc-load-balancer to cluster-template-vpc
  • Default vpc cluster creation with load balancer

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1392

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Remove code for VPC FIP

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 2dad7b8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/653fb6db75fcfb0008d45fbb
😎 Deploy Preview https://deploy-preview-1395--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 7, 2023
@Prajyot-Parab
Copy link
Contributor Author

/cc @Amulyam24 PTAL (fyi post merge we will need to change e2e job flavor as vpc)

mkumatag
mkumatag requested changes Sep 8, 2023
View reviewed changes
api/v1beta2/types.go Show resolved Hide resolved
@Prajyot-Parab Prajyot-Parab force-pushed the main branch 2 times, most recently from 2b1be16 to 42a02f5 Compare September 8, 2023 12:37
Amulyam24
Amulyam24 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
mkumatag
mkumatag requested changes Sep 14, 2023
View reviewed changes
controllers/ibmvpccluster_controller.go Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

/cc @Karthik-K-N

@Karthik-K-N
Copy link
Contributor

LGTM

@Prajyot-Parab
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@mkumatag
Copy link
Member

mkumatag commented Oct 3, 2023

@Prajyot-Parab why is this PR still hold? let me know once it is ready for the review

mkumatag

This comment was marked as outdated.

Sign in to view

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@mkumatag mkumatag removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 25, 2023
@Prajyot-Parab
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2023
mkumatag
mkumatag requested changes Oct 26, 2023
View reviewed changes
controllers/ibmvpccluster_controller.go Outdated Show resolved Hide resolved
controllers/ibmvpccluster_controller.go Outdated Show resolved Hide resolved
controllers/ibmvpccluster_controller.go Show resolved Hide resolved
controllers/ibmvpccluster_controller.go Outdated Show resolved Hide resolved
controllers/ibmvpccluster_controller.go Outdated Show resolved Hide resolved
controllers/ibmvpccluster_controller.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@Prajyot-Parab Prajyot-Parab force-pushed the main branch 2 times, most recently from 6ae4875 to c3dd362 Compare October 30, 2023 10:01
mkumatag
mkumatag requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, otherwise lgtm

controllers/ibmvpccluster_controller.go Outdated Show resolved Hide resolved
@Prajyot-Parab
Remove code for VPC FIP
2dad7b8 
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
mkumatag
mkumatag approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 034149e into kubernetes-sigs:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@relyt0925 relyt0925 Awaiting requested review from relyt0925

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

Assignees

@mkumatag mkumatag

@Amulyam24 Amulyam24

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate and remove code for VPC FIP
5 participants
@Prajyot-Parab @mkumatag @Karthik-K-N @k8s-ci-robot @Amulyam24