Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace k8s.gcr.io with registry.k8s.io #224

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 6, 2023

Issue #, if available: kubernetes/k8s.io#4738

Description of changes: This PR replaces all k8s.gcr.io references with registry.k8s.io. See the linked issue for more details.

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2023
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit 8c1e614
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/6405fc73f8795300089633df
😎 Deploy Preview https://deploy-preview-224--kubernetes-sigs-cluster-api-cloudstack.netlify.app/print
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Mar 6, 2023

/retest

@g-gaston
Copy link
Contributor

g-gaston commented Mar 6, 2023

thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@rohityadavcloud
Copy link
Member

/lgtm
/approve

I haven't checked/tested it though

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Mar 15, 2023

/test capi-provider-cloudstack-presubmit-build
/test capi-provider-cloudstack-presubmit-unit-test

@k8s-ci-robot
Copy link
Contributor

@xmudrii: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
capi-provider-cloudstack-presubmit-unit-test 8c1e614 link true /test capi-provider-cloudstack-presubmit-unit-test
capi-provider-cloudstack-presubmit-build 8c1e614 link true /test capi-provider-cloudstack-presubmit-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 15, 2023

@g-gaston @rohityadavcloud Those test failures don't seem to be related to my PR at all. Can you please assist here?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4, rohityadavcloud, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jweite-amazon
Copy link
Contributor

/lgtm

@jweite-amazon jweite-amazon merged commit 95ff824 into kubernetes-sigs:main Mar 16, 2023
@xmudrii xmudrii deleted the registry-k8s-io branch March 18, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants