Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cert-manager to v1.11.0 #3139

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Bump cert-manager to v1.11.0 #3139

merged 1 commit into from
Feb 3, 2023

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Feb 2, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the cert-manager component to recent release v1.11.0, keeping in sync with CAPI.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

I have tested this locally with make tilt-up and everything looks happy.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump cert-manager to v1.11.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2023
@mboersma mboersma marked this pull request as ready for review February 2, 2023 17:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2023
mboersma
mboersma commented Feb 2, 2023
View reviewed changes
Tiltfile Outdated Show resolved Hide resolved
mboersma
mboersma commented Feb 2, 2023
View reviewed changes
Tiltfile Outdated Show resolved Hide resolved
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 2, 2023
@mboersma mboersma added this to the v1.8 milestone Feb 2, 2023
mboersma
mboersma commented Feb 2, 2023
View reviewed changes
Tiltfile
@@ -410,7 +410,7 @@ include_user_tilt_files()
load("ext://cert_manager", "deploy_cert_manager")

if settings.get("deploy_cert_manager"):
deploy_cert_manager()
deploy_cert_manager(version = settings.get("cert_manager_version"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like cert_manager_version was unused, and we were getting the default version of v1.3.1 here.

@mboersma
Copy link
Contributor Author

mboersma commented Feb 2, 2023

/cherry-pick release-1.7

This goes along with bumping CAPI to v1.3.3, I'd argue.

@k8s-infra-cherrypick-robot
Copy link

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

This goes along with bumping CAPI to v1.3.3, I'd argue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor Author

mboersma commented Feb 2, 2023

/cherry-pick release-1.6

This is also part of the CAPI v1.2.10 release.

@k8s-infra-cherrypick-robot
Copy link

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

This is also part of the CAPI v1.2.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset
Copy link
Contributor

marosset commented Feb 2, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 29f2440d38d5cbc55cccba2208105f810fafceb9

CecileRobertMichon
CecileRobertMichon reviewed Feb 2, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Feb 2, 2023

/retest

Unrelated AKS provisioning failure.

@k8s-ci-robot k8s-ci-robot merged commit 824623e into kubernetes-sigs:main Feb 3, 2023
@k8s-infra-cherrypick-robot
Copy link

@mboersma: #3139 failed to apply on top of branch "release-1.7":

Applying: Bump cert-manager to v1.11.0
Using index info to reconstruct a base tree...
M	Tiltfile
Falling back to patching base and 3-way merge...
Auto-merging Tiltfile
CONFLICT (content): Merge conflict in Tiltfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump cert-manager to v1.11.0
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

This goes along with bumping CAPI to v1.3.3, I'd argue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@mboersma: #3139 failed to apply on top of branch "release-1.6":

Applying: Bump cert-manager to v1.11.0
Using index info to reconstruct a base tree...
M	Tiltfile
M	hack/install-cert-manager.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/install-cert-manager.sh
CONFLICT (content): Merge conflict in hack/install-cert-manager.sh
Auto-merging Tiltfile
CONFLICT (content): Merge conflict in Tiltfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump cert-manager to v1.11.0
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

This is also part of the CAPI v1.2.10 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma deleted the bump-cert-manager branch February 3, 2023 00:35
@mboersma
Copy link
Contributor Author

mboersma commented Feb 3, 2023 •
edited
Loading

I'll see about creating manual cherry-pick PRs for this since prow couldn't.

Edit: See #3143 and #3144.

This was referenced Feb 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

@marosset marosset Awaiting requested review from marosset

Assignees

@CecileRobertMichon CecileRobertMichon

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@mboersma @k8s-infra-cherrypick-robot @marosset @k8s-ci-robot @CecileRobertMichon