Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced all instances of reflect.DeepEqual() with cmp.Equal() #3342

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Replaced all instances of reflect.DeepEqual() with cmp.Equal() #3342

merged 1 commit into from
Mar 29, 2022

Conversation

VibhorChinda
Copy link
Contributor

@VibhorChinda VibhorChinda commented Mar 23, 2022 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:
This PR Replaces all instances of reflect.DeepEqual() in the codebase.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #3259

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Replaced all  instances of reflect.DeepEqual()  in the codebase with cmp.Equal()

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

@VibhorChinda: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @VibhorChinda. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot requested review from pydctw and shivi28 March 23, 2022 17:28
@VibhorChinda VibhorChinda mentioned this pull request Mar 23, 2022
Closed
4 tasks
@Ankitasw
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2022
Ankitasw
Ankitasw reviewed Mar 24, 2022
View reviewed changes
api/v1alpha4/tags.go Show resolved Hide resolved
api/v1beta1/tags.go Show resolved Hide resolved
@VibhorChinda
Copy link
Contributor Author

/retest

@VibhorChinda VibhorChinda requested a review from Ankitasw March 24, 2022 07:42
@Ankitasw
Copy link
Member

Ankitasw commented Mar 24, 2022 •
edited
Loading

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@sedefsavas
Copy link
Contributor

/lgtm

cc @richardcase for approve.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2022
@richardcase
Copy link
Member

@VibhorChinda - would you be able to rebase? I will then approve

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 26, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/contains-merge-commits labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@Ankitasw
Copy link
Member

/lgtm
cc @richardcase for approval.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2022
@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@richardcase
Copy link
Member

I have captured the Equals deprecation on Tags in #2355

@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e

Tests are passing now.

@Ankitasw
Copy link
Member

looks like somehow my last comment triggered test again 🤦

@VibhorChinda
Copy link
Contributor Author

All passing now :))
cc @Ankitasw @richardcase

@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 760e4e7 into kubernetes-sigs:main Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Mar 29, 2022
@VibhorChinda
Copy link
Contributor Author

My first PR merged in CAPA 🎉

@VibhorChinda VibhorChinda deleted the test branch March 29, 2022 17:47
@VibhorChinda VibhorChinda mentioned this pull request Nov 2, 2022
Closed
9 tasks
@VibhorChinda VibhorChinda mentioned this pull request May 24, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pydctw pydctw Awaiting requested review from pydctw

@shivi28 shivi28 Awaiting requested review from shivi28

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

Assignees

@sedefsavas sedefsavas

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VibhorChinda @k8s-ci-robot @Ankitasw @sedefsavas @richardcase