Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add IPAM provider support to Cluster API Operator Helm chart #688

Merged
merged 2 commits into from
Feb 12, 2025
Merged

✨ Add IPAM provider support to Cluster API Operator Helm chart #688

merged 2 commits into from
Feb 12, 2025

Conversation

rgeraskin
Copy link
Contributor

What this PR does / why we need it:

This PR introduces a Helm chart template for deploying IPAMProvider.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 25, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @rgeraskin!

It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rgeraskin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 25, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit b8d3328
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67977528a0315c0008095c2f
😎 Deploy Preview https://deploy-preview-688--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 25, 2025
@furkatgofurov7
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2025
@furkatgofurov7
Copy link
Member

@rgeraskin can you run make generate and push any changes it generates to fix the failing verify job?

@rgeraskin
Copy link
Contributor Author

/retest

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Jan 27, 2025 •
edited
Loading

@rgeraskin thanks for the PR and working on this! I took a closer look and noticed:

  1. we disabled IPAM e2e minimal tests some time ago in 96c9be9 that was introduced as part of a bigger PR. Can we make sure they are enabled back and passing in this PR? - taken care already in ✨ Add OCI source for provider ConfigMap preparation #683 apparently.
  2. we need to test the new ipam chart in https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/helm_test.go the same way as add-on provider for example. For reference and inspiration, you could take a look at https://github.com/kubernetes-sigs/cluster-api-operator/pull/286/files#diff-364834eec4f925bf65cd615cb76b3d17502a472b55f9555bde0d7419dfbda71d (cc @alexander-demicev)

@rgeraskin rgeraskin mentioned this pull request Jan 28, 2025
Merged
Danil-Grigorev
Danil-Grigorev approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

IPAM tests are enabled again after #683, but they don’t touch this PR.

Would be great to have a simple TC for the chart template with this configuration

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@rgeraskin rgeraskin marked this pull request as draft January 28, 2025 17:46
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
@furkatgofurov7
Copy link
Member

@rgeraskin please let me know if you need any further clarification or help with taking this out of the draft 🙂

anmazzotti
anmazzotti approved these changes Feb 12, 2025
View reviewed changes
Copy link

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@anmazzotti: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Danil-Grigorev Danil-Grigorev marked this pull request as ready for review February 12, 2025 09:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Feb 12, 2025 •
edited
Loading

/lgtm

we can follow-up on helm tests

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4efe8f524902201189eac015e7d4fdd187a00c73

@k8s-ci-robot k8s-ci-robot merged commit 6b72fcd into kubernetes-sigs:main Feb 12, 2025
14 checks passed
@rgeraskin rgeraskin mentioned this pull request Feb 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

@anmazzotti anmazzotti anmazzotti approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@Fedosin Fedosin Awaiting requested review from Fedosin

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

Assignees

@furkatgofurov7 furkatgofurov7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rgeraskin @k8s-ci-robot @furkatgofurov7 @Danil-Grigorev @anmazzotti