🐛 Collect correct manifest config map per provider while performing upgrade #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
99a8545 to
a928a92
Compare
…rade Clusterctl upgrade logic validates other installed providers, while perfoming upgrade for version compatibility. Operator stores this data in a ConfigMap to allow air-gapped support. This ensures we fetch correct configMap first, to validate version against correct metadata.yaml. Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
565d8df to
5eccd0d
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
|
Tested this PR and it works well. Thanks a lot @Danil-Grigorev! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: ed7764e171a627b19a8842cd40b5204ebd9ddf29
|
|
/cherrypick release-0.9 |
|
@Fedosin: new pull request created: #452 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Clusterctl upgrade logic validates other installed providers, while performing upgrade for version compatibility. Operator stores this data in a ConfigMap to allow air-gapped support. This ensures we fetch correct configMap first, to validate version against correct metadata.yaml.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #446