-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.28] Fix : Enable system tag support prefix match #8151
[release-1.28] Fix : Enable system tag support prefix match #8151
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
In the logic for updating tags, if we define
systemTags
, any tags not included insystemTags
will be deleted. However, this behavior can cause some AKS-managed tags to be mistakenly deleted. Adding all AKS-managed tags individually tosystemTags
would makesystemTags
excessively long and difficult to maintain.This PR enhances the comparison logic between tags and
systemTags
by introducing prefix matching. With this change, we can add a prefix likeaks-managed
tosystemTags
, and any tags starting withaks-managed
, such asaks-managed-cluster-name
oraks-managed-cluster-rg
, will be successfully matched and retained, preventing accidental deletion.This approach reduces the size of
systemTags
while maintaining flexibility and ensuring that AKS-managed tags are preserved.Which issue(s) this PR fixes:
Fixes #8053
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: