Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.27] Make a windows cloud-node-manager image based off the host-process-containers base image #6774

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #6318

/assign nojnhuh

Add a windows cloud-node-manager image based off of the host-process-containers base image

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign nilo19 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 6, 2024

/assign @nilo19

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 6, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz-1-27 8e171cd link true /test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz-1-27
pull-cloud-provider-azure-e2e-ccm-capz-1-27 8e171cd link true /test pull-cloud-provider-azure-e2e-ccm-capz-1-27
pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-27 8e171cd link true /test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-27

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nilo19
Copy link
Contributor

nilo19 commented Aug 7, 2024

@nojnhuh 1.27 and 1.28 failed due to
s: "parameter 'activeDirectoryEndpoint' cannot be empty",

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 7, 2024

@nilo19 Do you know why 1.29 and 1.30 don't fail with the same error?

@nilo19
Copy link
Contributor

nilo19 commented Aug 7, 2024

@nilo19 Do you know why 1.29 and 1.30 don't fail with the same error?

I thought this would be a capz problem, but now I don't think so. Let me do more research on cloud provider. Thanks!

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 7, 2024

Could it be because #6622 has only been backported to 1.29 and 1.30?

@nilo19
Copy link
Contributor

nilo19 commented Aug 7, 2024

Could it be because #6622 has only been backported to 1.29 and 1.30?

It's here https://github.com/kubernetes-sigs/cloud-provider-azure/pull/6693/files

@nilo19 nilo19 merged commit 8e4d892 into kubernetes-sigs:release-1.27 Aug 7, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants