fix: ignore Windows 2019 in ensureVMSSInPool for IPv6 backend pools only
#6316
Conversation
|
Hi @tyler-lloyd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
does it affect ip-based pool? |
maybe? I'm not as familiar with ip-based pools. do customers have to opt-in to use that feature? would there be an error if someone is using ip pools but the VM has no IPv6 IP? if yes, then we'd want to also have the same exclusion for Windows2019 nodes as I'm doing in this PR. |
|
/test pull-cloud-provider-azure-e2e-capz |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lzhecheng, tyler-lloyd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| return false | ||
| } | ||
|
|
||
| osVersion := strings.Split(parts[len(parts)-1], ".") |
There was a problem hiding this comment.
Can we parse the string by regexp, to get rid of those Split?
|
/cherrypick release-1.30 |
|
/cherrypick release-1.29 |
|
/cherrypick release-1.28 |
|
/cherrypick release-1.27 |
|
@nilo19: new pull request created: #6326 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nilo19: new pull request created: #6327 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nilo19: new pull request created: #6328 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nilo19: new pull request created: #6329 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-1.28 |
|
/cherrypick release-1.27 |
|
@MartinForReal: new pull request created: #6379 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@MartinForReal: new pull request created: #6380 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
doesn't try to add Windows 2019 VMSS to IPv6 backend pools because 2019 will never support IPv6 so it shouldn't be added.
Which issue(s) this PR fixes:
Fixes #6315
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: