Fix generating NSG rules while using shared BYO public IP #6186
Conversation
|
Hi @zarvd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e17b28f to
f62b6ab
Compare
| @@ -830,6 +830,153 @@ var _ = Describe("Network security group", Label(utils.TestSuiteLabelNSG), func( | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| When("creating 2 LoadBalancer services with shared BYO public IP", func() { | |||
There was a problem hiding this comment.
Thanks adding a set of new tests
/ok-to-test
3fdbe49 to
dc8fa09
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
dc8fa09 to
d091723
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, zarvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
bug: When creating LoadBalancer services with a shared BYO public IP, the NSG rules are not generated correctly.
how to reproduce:
service.beta.kubernetes.io/azure-pip-name: {the PIP name}This PR would list all services and then filter by IP address instead of using PIP tags when checking for services with a shared PIP.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: