-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ListWithInstanceView to Azure vm client #6166
Add ListWithInstanceView to Azure vm client #6166
Conversation
|
Welcome @wenxuan0923! |
Hi @wenxuan0923. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ab38876
to
2c72e8f
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks adding the new client
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, wenxuan0923 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
We are currently working on the autoscaling feature for single instance pool (vms pool) - CAS will scale down vms pool with Deallocate/Delete mode based on the agentpool's setting. We will need the power state of a VM to know whether it's running or being deallocated, which is located in the instance view of VM.
CAS (Cluster-Autoscaler) relies on cloud provider to list VMs in the node resource group. This PR add a new ListWithInstanceView method to list all VMs in a resource group with expanded instance view.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: