Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getVMManagementTypeByIPConfigurationID() #5948

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix getVMManagementTypeByIPConfigurationID() #5948

merged 1 commit into from
Apr 19, 2024

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Force cache refresh for getVMManagementTypeByIPConfigurationID(). The reason is that when a new standalone VM is included in the cluster, CCM cannot tell its VM type with stale cache.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Force cache refresh for getVMManagementTypeByIPConfigurationID(). The reason is that when a new standalone VM is included in the cluster, CCM cannot tell its VM type with stale cache.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@lzhecheng lzhecheng force-pushed the getVMManagementTypeByIPConfigurationID-cache-force-refresh branch from ed80312 to 47e3035 Compare April 18, 2024 07:30
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@lzhecheng lzhecheng force-pushed the getVMManagementTypeByIPConfigurationID-cache-force-refresh branch from 47e3035 to feccc62 Compare April 18, 2024 07:44
feiskyer
feiskyer reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the unit test failures?

@lzhecheng lzhecheng force-pushed the getVMManagementTypeByIPConfigurationID-cache-force-refresh branch from feccc62 to 386f3e6 Compare April 19, 2024 01:45
@lzhecheng
Fix getVMManagementTypeByIPConfigurationID()
223c621 
If VM not existing in cache, force cache refresh again.
If the node is not in the cache, assume the node has joined after
the last cache refresh and attempt to refresh the cache.

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@lzhecheng lzhecheng force-pushed the getVMManagementTypeByIPConfigurationID-cache-force-refresh branch from 386f3e6 to 223c621 Compare April 19, 2024 01:56
@lzhecheng
Copy link
Contributor Author

Could you fix the unit test failures?

Thank you for reminding. This failure comes from the log change in this PR and it is fixed.

tallaxes
tallaxes approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng, tallaxes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feiskyer
feiskyer reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2024
@feiskyer
Copy link
Member

/retest

@feiskyer
Copy link
Member

/cherry-pick release-1.29

@k8s-infra-cherrypick-robot
Copy link

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.29 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member

/cherry-pick release-1.28

@k8s-infra-cherrypick-robot
Copy link

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.28 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member

/cherry-pick release-1.27

@k8s-infra-cherrypick-robot
Copy link

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 86dc4aa into kubernetes-sigs:master Apr 19, 2024
18 checks passed
@k8s-infra-cherrypick-robot
Copy link

@feiskyer: new pull request created: #5970

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 19, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@feiskyer: new pull request created: #5971

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 19, 2024
Merged
Merged
@k8s-infra-cherrypick-robot
Copy link

@feiskyer: new pull request created: #5972

In response to this:

/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng deleted the getVMManagementTypeByIPConfigurationID-cache-force-refresh branch April 23, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@tallaxes tallaxes tallaxes approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lzhecheng @k8s-ci-robot @feiskyer @k8s-infra-cherrypick-robot @tallaxes