-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nfs file share created in storage account that has smb file share #5619
fix: nfs file share created in storage account that has smb file share #5619
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
609c094
to
31da42f
Compare
/hold |
/retest |
/hold cancel |
/cherrypick release-1.29 |
@andyzhangx: new pull request created: #5634 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.28 |
@andyzhangx: new pull request created: #5635 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: nfs file share created in storage account that has smb file share
by default, this driver would search a storage account when creating a new nfs file share, while if storage account with matching sku already exists, this driver does not check EnableHTTPSTrafficOnly property in storage account, which means there is possibility that nfs file share is created in a storage account that has smb file share, finally lead to nfs file share mount permission error
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: