-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a cloud-node-manager sidecar container called health-probe-proxy to transfer the traff… #5180
feat: Add a cloud-node-manager sidecar container called health-probe-proxy to transfer the traff… #5180
Conversation
d0b7459
to
59e64db
Compare
/test pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz |
/retest |
@@ -0,0 +1,38 @@ | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add the deployment charts into helm charts as part of cnm deployment (a new sidecar for it). And please add a new helm config to enable this sidecar, which is disable by default during preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/hold |
testing windows |
59e64db
to
52550f8
Compare
52550f8
to
c0cd776
Compare
/retest |
enableHealthProbeProxy: false | ||
healthCheckPort: 10356 | ||
targetPort: 10256 | ||
healthProbeProxyImage: "ss104301/health-probe-proxy:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use my personal image as a placeholder and will replace to the mcr image when they are ready.
c0cd776
to
73cbfef
Compare
labels: | ||
component: health-probe-proxy | ||
kubernetes.io/cluster-service: "true" | ||
addonmanager.kubernetes.io/mode: Reconcile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useful when using addon manager to deploy health probe proxy.
…ic from port 10356 to the kube-proxy health check server port 10256. This daemonset will parse the proxy protocol packet data unit when the user uses private link service integrated with the service annotation and set the proxy protocol annotation. In this case the kube-proxy health probe server will not read the health probe request from the SLB and fails the health check.
73cbfef
to
d0f769f
Compare
/retest |
@jwtty can you help approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ic from port 10356 to the kube-proxy health check server port 10256. This sidecar will parse the proxy protocol packet data unit when the user uses private link service integrated with the service annotation and set the proxy protocol annotation. In this case the kube-proxy health probe server will not read the health probe request from the SLB and fails the health check.
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: Add a daemonset called health-probe-proxy to transfer the traffic from port 10356 to the kube-proxy health check server port 10256. This daemonset will parse the proxy protocol packet data unit when the user uses private link service integrated with the service annotation and set the proxy protocol annotation. In this case the kube-proxy health probe server will not read the health probe request from the SLB and fails the health check.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: