fix: shared probe should not be removed if there are other services u… #5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16c5d32 to
b466c99
Compare
|
/retest |
feiskyer
reviewed
Nov 23, 2023
| @@ -197,3 +203,144 @@ func TestFindProbe(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestShouldKeepSharedProbe(t *testing.T) { | |||
There was a problem hiding this comment.
Thanks adding the unit tests. Since this is an important feature fix, could you also add an e2e test case?
There was a problem hiding this comment.
We need to create a new prowjob for this feature because we need to modify the azure.json. So need to merge this fix first.
…sing it when deleting a service
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sing it when deleting a service
What type of PR is this?
/kind bug
What this PR does / why we need it:
We remove the health probe related to the service when we delete the service, and this includes removing the shared health probe. But the shared probe should not be removed if there are other services using it. This PR checks if there are other services referencing the shared probe before removing it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: