-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 2020-07-01/network #502
Update to 2020-07-01/network #502
Conversation
Hi @MirzaSikander. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Refer #403, the new network API 2020-08-01 has introduced a breaking change about the availability zone. We need to ensure zone-redundant resources are created on AZ regions. Do you any API to query AZ regions? /hold |
According to our discussion, mirza would use 2020-07-01, which is sufficient for him. |
I have updated the title and the pull request description to indicate that we are only switching to 2020-07-01. |
As mentioned in the pull request description, a test TestGetVirtualMachineScaleSetNetworkInterface in pkg/azureclients/interfaceclient/azure_interfaceclient_test.go had to be updated because it was setting a readonly field which doesn't get marshalled anymore. More info here: |
Could you also update the APIVersion for all the updated clients? one example is here (please do not touch AzureStackCloudAPIVersion): cloud-provider-azure/pkg/azureclients/loadbalancerclient/interface.go Lines 30 to 31 in 21a604f
|
Could you fix this test failure? |
@feiskyer The clients have been updated and the test is fixed. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, MirzaSikander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Updates all the references for azure network API to point to
2020-07-01
. This is needed to consume new features likeEdge Zones
. This pull request only contains the update to new version so that it can be tested in isolation.We decided not to update to
2020-08-01
because there are some concerns about breaking changes:#403
Special notes for your reviewer:
Apart from the reference updates, there is only one logic change, which is in
pkg/provider/azure_standard.go
. Apparently, the property type for the fieldInterfacePropertiesFormat.ProvisioningState
updated in between API versions, and is no longer a pointer type. Opened a bug on the azure sdk team: Azure/azure-sdk-for-go#14261Also a test
TestGetVirtualMachineScaleSetNetworkInterface
inpkg/azureclients/interfaceclient/azure_interfaceclient_test.go
had to be updated because it was setting a readonly field which doesn't get marshalled anymore. More info here:Azure/azure-sdk-for-go#14263
Release note: