Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2020-07-01/network #502

Merged

Conversation

MirzaSikander
Copy link
Contributor

@MirzaSikander MirzaSikander commented Feb 2, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
Updates all the references for azure network API to point to 2020-07-01 . This is needed to consume new features like Edge Zones. This pull request only contains the update to new version so that it can be tested in isolation.
We decided not to update to 2020-08-01 because there are some concerns about breaking changes:
#403

Special notes for your reviewer:
Apart from the reference updates, there is only one logic change, which is in pkg/provider/azure_standard.go. Apparently, the property type for the field InterfacePropertiesFormat.ProvisioningState updated in between API versions, and is no longer a pointer type. Opened a bug on the azure sdk team: Azure/azure-sdk-for-go#14261

Also a test TestGetVirtualMachineScaleSetNetworkInterface in pkg/azureclients/interfaceclient/azure_interfaceclient_test.go had to be updated because it was setting a readonly field which doesn't get marshalled anymore. More info here:
Azure/azure-sdk-for-go#14263

Release note:

Updates all the references for azure network API to point to `2020-07-01` which is the latest API Version

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @MirzaSikander. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 2, 2021
@nilo19
Copy link
Contributor

nilo19 commented Feb 2, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2021
@feiskyer
Copy link
Member

feiskyer commented Feb 2, 2021

Refer #403, the new network API 2020-08-01 has introduced a breaking change about the availability zone. We need to ensure zone-redundant resources are created on AZ regions.

Do you any API to query AZ regions?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
@nilo19
Copy link
Contributor

nilo19 commented Feb 2, 2021

According to our discussion, mirza would use 2020-07-01, which is sufficient for him.

@MirzaSikander MirzaSikander changed the title Update to 2020-08-01/network Update to 2020-07-01/network Feb 2, 2021
@MirzaSikander
Copy link
Contributor Author

I have updated the title and the pull request description to indicate that we are only switching to 2020-07-01.

@MirzaSikander
Copy link
Contributor Author

As mentioned in the pull request description, a test TestGetVirtualMachineScaleSetNetworkInterface in pkg/azureclients/interfaceclient/azure_interfaceclient_test.go had to be updated because it was setting a readonly field which doesn't get marshalled anymore. More info here:
Azure/azure-sdk-for-go#14263

@feiskyer
Copy link
Member

feiskyer commented Feb 3, 2021

Could you also update the APIVersion for all the updated clients? one example is here (please do not touch AzureStackCloudAPIVersion):

// APIVersion is the API version for network.
APIVersion = "2019-06-01"

@feiskyer
Copy link
Member

feiskyer commented Feb 3, 2021

As mentioned in the pull request description, a test TestGetVirtualMachineScaleSetNetworkInterface in pkg/azureclients/interfaceclient/azure_interfaceclient_test.go had to be updated because it was setting a readonly field which doesn't get marshalled anymore. More info here:

Could you fix this test failure?

@MirzaSikander
Copy link
Contributor Author

@feiskyer The clients have been updated and the test is fixed.

@nilo19
Copy link
Contributor

nilo19 commented Feb 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, MirzaSikander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 90b23de into kubernetes-sigs:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants