-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report vmPowerStateUnknown when vmssVM intanceView is nil #4798
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwtty The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Do we need to change the counterparts of availabilitySet and vmss flex as well? |
Thanks, fixed those two also. |
/lgtm |
/cherrypick release-1.28 |
/cherrypick release-1.27 |
@jwtty: new pull request created: #4804 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jwtty: new pull request created: #4805 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.26 |
/cherrypick release-1.25 |
@jwtty: new pull request created: #4806 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jwtty: #4798 failed to apply on top of branch "release-1.25":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When vmssVM instanceView or instanceView.Status is nil, it means the vm is under deleting, and GetPowerState() should not return powerStateStopped. This can result in a deleting vm being considered mistakenly as stopped and thus node shutdown/node out-of-service taints are added.
Fix log also.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: