Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.27] Cherrypick FIP, NSG dualstack change #4397

Merged
merged 5 commits into from
Aug 9, 2023
Merged

[release-1.27] Cherrypick FIP, NSG dualstack change #4397

merged 5 commits into from
Aug 9, 2023

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

[DualStack] Support NSG and clean LBs
* Support NSG and clean LBs for dualstack
* Support related UTs for dualstack
* Refactor

[IPv6] Fix reconcileFrontendIPConfigs()
Current logic handles lb.FrontendIPConfigurations according
to Service's IP family, which is incorrect. For an IPv6 cluster,
there're still some IPv4 FIPs due to Azure limitation, which
will be removed. For an IPv4 cluster, all resources are of IPv4,
which is not affected.

[e2e] Adjust for IPv6 VMSS

[DualStack] Support FrontendIPConfig and reconcileLB()
* DualStack feature code
* Refactor related functions and methods
* Refactor and add new UTs

[Refactor] Drop RG param in getXXXID()
Resource group name can be got from az.getLoadBalancerResourceGroup().

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[DualStack] Support FrontendIPConfig and reconcileLB() * DualStack feature code * Refactor related functions and methods * Refactor and add new UTs
[IPv6] Fix reconcileFrontendIPConfigs(). Current logic handles lb.FrontendIPConfigurations according to Service's IP family, which is incorrect. For an IPv6 cluster, there're still some IPv4 FIPs due to Azure limitation, which will be removed. For an IPv4 cluster, all resources are of IPv4, which is not affected.
Support NSG and clean LBs for dualstack

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@lzhecheng
[Refactor] Drop RG param in getXXXID()
58c1cc0 
Resource group name can be got from az.getLoadBalancerResourceGroup().

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@lzhecheng
[DualStack] Support FrontendIPConfig and reconcileLB()
f96f88b 
* DualStack feature code
* Refactor related functions and methods
* Refactor and add new UTs

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@lzhecheng
[e2e] Adjust for IPv6 VMSS
84349cb 
Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@lzhecheng
[IPv6] Fix reconcileFrontendIPConfigs()
b5a908e 
Current logic handles lb.FrontendIPConfigurations according
to Service's IP family, which is incorrect. For an IPv6 cluster,
there're still some IPv4 FIPs due to Azure limitation, which
will be removed. For an IPv4 cluster, all resources are of IPv4,
which is not affected.

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 2, 2023
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-dualstack-capz-1-27
/test pull-cloud-provider-azure-e2e-ccm-dualstack-vmss-capz-1-27
/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-27
/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-27

@lzhecheng lzhecheng changed the title [release-1.27] Cherrypick FIP, NSG dualstack change [WIP][release-1.27] Cherrypick FIP, NSG dualstack change Aug 2, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2023
@lzhecheng
Copy link
Contributor Author

/retest

@lzhecheng
[DualStack] Support NSG and clean LBs
b8da63b 
* Support NSG and clean LBs for dualstack
* Support related UTs for dualstack
* Refactor

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@lzhecheng lzhecheng force-pushed the cp-dualstack-fip-nsg-1.27 branch from 9470cf9 to b8da63b Compare August 8, 2023 10:37
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-dualstack-capz-1-27
/test pull-cloud-provider-azure-e2e-ccm-dualstack-vmss-capz-1-27
/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-27
/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-27

@lzhecheng lzhecheng changed the title [WIP][release-1.27] Cherrypick FIP, NSG dualstack change [release-1.27] Cherrypick FIP, NSG dualstack change Aug 9, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2023
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 85ab58b into kubernetes-sigs:release-1.27 Aug 9, 2023
@lzhecheng lzhecheng deleted the cp-dualstack-fip-nsg-1.27 branch August 9, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzhecheng @k8s-ci-robot @MartinForReal