Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bugs regarding multiple slbs #4289

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: fix bugs regarding multiple slbs #4289

merged 1 commit into from
Jul 25, 2023

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jul 14, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. getServiceLoadBalancer should return the existing lb object instead of creating a new one when a service is being moved from another lb to this one.
  2. existingLBs should be updated when the lb is updated to prevent potential etag mismatches in EnsureHostsInPool.
  3. Should skip non-existent lb when arranging nodes.

Which issue(s) this PR fixes:

Fixes #
Related: 4013

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: update the lb list after changing lb to prevent etag mismatches
fix: return the existing lb  it if the lb exists without creating a new lb when the service was moved to the lb
fix: should skip non-existent lb when arranging nodes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2023
@nilo19 nilo19 changed the title fix: fix two bugs regarding multiple slbs fix: fix 3 bugs regarding multiple slbs Jul 16, 2023
@nilo19
Copy link
Contributor Author

nilo19 commented Jul 19, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

2 similar comments
@nilo19
Copy link
Contributor Author

nilo19 commented Jul 19, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

@nilo19
Copy link
Contributor Author

nilo19 commented Jul 19, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

@nilo19
Copy link
Contributor Author

nilo19 commented Jul 19, 2023

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Jul 19, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz

@nilo19
Copy link
Contributor Author

nilo19 commented Jul 20, 2023

/retest

@nilo19 nilo19 changed the title fix: fix 3 bugs regarding multiple slbs fix: fix bugs regarding multiple slbs Jul 20, 2023
@nilo19 nilo19 force-pushed the feat/multi-slb/fix/service-selection branch from 0b26912 to 6af392a Compare July 20, 2023 07:22
@nilo19
Copy link
Contributor Author

nilo19 commented Jul 20, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

@nilo19 nilo19 force-pushed the feat/multi-slb/fix/service-selection branch from 6af392a to 8283c19 Compare July 20, 2023 10:16
@nilo19
Copy link
Contributor Author

nilo19 commented Jul 20, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

@nilo19
Copy link
Contributor Author

nilo19 commented Jul 20, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz

@nilo19
fix: update the lb list after changing lb to prevent etag mismatches
bda7c54 
fix: return the existing lb  it if the lb exists without creating a new lb when the service was moved to the lb
fix: should skip non-existent lb when arranging nodes
chore: fix multi-slb e2e test
@nilo19 nilo19 force-pushed the feat/multi-slb/fix/service-selection branch from 8283c19 to bda7c54 Compare July 25, 2023 08:30
@nilo19
Copy link
Contributor Author

nilo19 commented Jul 25, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

feiskyer
feiskyer reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit c18b82b into kubernetes-sigs:master Jul 25, 2023
@nilo19 nilo19 deleted the feat/multi-slb/fix/service-selection branch July 25, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@MartinForReal MartinForReal MartinForReal left review comments

@jwtty jwtty jwtty left review comments

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nilo19 @k8s-ci-robot @feiskyer @MartinForReal @jwtty