feat: support node selection for multiple standard load balancers #4201
Conversation
|
/retest |
1 similar comment
|
/retest |
pkg/provider/azure_loadbalancer.go
Outdated
| } | ||
| } | ||
|
|
||
| func (az *Cloud) removeNodeFromLBConfig(nodeNameToLBConfigIDXMap map[string]int, nodeName string) string { |
There was a problem hiding this comment.
could you add comments for the newly added functions?
pkg/provider/azure.go
Outdated
| multipleStandardLoadBalancerConfigurationsSynced bool | ||
| // nodesWithCorrectLoadBalancerByPrimaryVMSet marks nodes that are matched with load balancers by primary vmSet. | ||
| nodesWithCorrectLoadBalancerByPrimaryVMSet sets.Set[string] |
There was a problem hiding this comment.
the property is a little confusing and a lock should be added to avoid race conditions
There was a problem hiding this comment.
the service reconciliation is triggered in serial, do we still need a lock to guard this?
There was a problem hiding this comment.
It may be updated by different go routines, e.g. service controller and node watcher
There was a problem hiding this comment.
please check the new commit
88a7901 to
34b9faa
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
205ac9f to
b0b436b
Compare
|
@feiskyer squashed commits and rebased. |
b0b436b to
bd9fa86
Compare
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support node selection for multiple standard load balancers.
When nodes are created, each node will be evaluated to see what load balancer it should be placed into.
Valid placement targets will be determined as follows (rules match from top to bottom, first match wins):
After the list of potential placement targets has been calculated, the node should be placed into the kubernetes backend pool of the load balancer with the fewest number of nodes already assigned.
Which issue(s) this PR fixes:
Fixes #
Related: #4013
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: