[ARG] Add an option to disable API call cache #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lzhecheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0e57022 to
d6b67e2
Compare
d6b67e2 to
75d20f8
Compare
3386915 to
e1bb0d5
Compare
|
/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz |
e1bb0d5 to
263fa0a
Compare
263fa0a to
bf8fc1e
Compare
bf8fc1e to
b99a610
Compare
| // NewTimedcache creates a new TimedCache. | ||
| func NewTimedcache(ttl time.Duration, getter GetFunc) (*TimedCache, error) { | ||
| // NewTimedCache creates a new azcache.Resource. | ||
| func NewTimedCache(ttl time.Duration, getter GetFunc, disabled bool) (Resource, error) { |
There was a problem hiding this comment.
getter is only used by apicaller. Maybe we can create another newapicaller func for apicaller?
And we also need another new function to assemble Resource impl based on the config(cacheDisabled)
Last but not least, we also need to generate mock for ut.
There was a problem hiding this comment.
Do you mean a New() methods is needed for Resource interface?
| @@ -742,6 +745,10 @@ func (az *Cloud) getPutVMSSVMBatchSize() int { | |||
| } | |||
|
|
|||
| func (az *Cloud) initCaches() (err error) { | |||
There was a problem hiding this comment.
we can init cache at creation time.
There was a problem hiding this comment.
What's the creation time? Could you please share which line of the code?
New option: disableAPICallCache When ARG is enabled, this option should be true. Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
b99a610 to
5d65ed3
Compare
|
/lgtm |
|
Fixed: #4130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
[ARG] Add an option to disable API call cache
New option: disableAPICallCache
When ARG is enabled, this option should be true.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: