Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vmssflex ensureBackendPoolDeletedFromNode #4074

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix vmssflex ensureBackendPoolDeletedFromNode #4074

merged 1 commit into from
Jun 12, 2023

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix vmssflex ensureBackendPoolDeletedFromNode

  • Fix loop pointer issue
  • Use lock on nicUpdated var
  • Fix log format

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix vmssflex ensureBackendPoolDeletedFromNode
* Fix loop pointer issue
* Use lock on nicUpdated var
* Fix log format

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 8, 2023
@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 664640e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/6482bfcb2b26890008adcb98

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer June 8, 2023 23:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nilo19 June 8, 2023 23:40
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2023
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz

jwtty
jwtty reviewed Jun 9, 2023
View reviewed changes
pkg/provider/azure_vmss.go Outdated
@@ -1906,7 +1907,9 @@ func (ss *ScaleSet) ensureBackendPoolDeleted(service *v1.Service, backendPoolIDs
return rerr.Error()
}

ss.lockMap.LockEntry(updatedVMLock)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use atomic.Store() instead of lock?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what purpose? atomic is never used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use atomic now.
"They are lockless and generally implemented directly at hardware level"
https://go101.org/article/concurrent-atomic-operation.html

@lzhecheng lzhecheng force-pushed the fix-vmssflex branch 2 times, most recently from 2f94557 to 187eb2b Compare June 9, 2023 05:58
@lzhecheng
Fix vmssflex ensureBackendPoolDeletedFromNode
664640e 
* Fix loop pointer issue
* Use atomic operation on nicUpdated var
* Fix log format

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.27

@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit e080c10 into kubernetes-sigs:master Jun 12, 2023
@lzhecheng lzhecheng deleted the fix-vmssflex branch June 12, 2023 06:36
@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: new pull request created: #4085

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwtty jwtty jwtty left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lzhecheng @k8s-ci-robot @MartinForReal @k8s-infra-cherrypick-robot @jwtty