apply the custom probe configs when externalTrafficPolicy is local and PLSProxyProtocol is enabled. #3931
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
|
/assign @jwtty |
pkg/provider/azure_loadbalancer.go
Outdated
| @@ -2381,7 +2381,7 @@ func (az *Cloud) getExpectedLBRules( | |||
| // healthcheck proxy server serves http requests | |||
| // https://github.com/kubernetes/kubernetes/blob/7c013c3f64db33cf19f38bb2fc8d9182e42b0b7b/pkg/proxy/healthcheck/service_health.go#L236 | |||
| var nodeEndpointHealthprobe *network.Probe | |||
| if servicehelpers.NeedsHealthCheck(service) { | |||
| if servicehelpers.NeedsHealthCheck(service) && !(consts.IsPLSEnabled() && consts.IsPLSProxyProtocolEnabled(service.Annotations)) { | |||
…yProtocol is enabled
|
/lgtm |
|
/cherrypick release-1.27 |
|
@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.26 |
|
@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.26 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.25 |
|
@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.25 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.24 |
|
@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.24 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@MartinForReal: new pull request created: #3934 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@MartinForReal: new pull request created: #3935 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@MartinForReal: new pull request created: #3936 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@MartinForReal: new pull request created: #3937 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.26 |
|
@lzhecheng: new pull request created: #3944 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.27 |
|
@lzhecheng: new pull request created: #3945 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.27 |
|
@MartinForReal: new pull request could not be created: failed to create pull request against kubernetes-sigs/cloud-provider-azure#release-1.27 from head k8s-infra-cherrypick-robot:cherry-pick-3931-to-release-1.27: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-3931-to-release-1.27."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.25 |
|
@lzhecheng: new pull request created: #3946 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.24 |
|
@lzhecheng: new pull request created: #3949 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
apply the custom probe configs when externalTrafficPolicy is local and PLSProxyProtocol is enabled.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: