Fix incorrect EnableTCPReset for non-TCP protocols

[lzhecheng]

Signed-off-by: Zhecheng Li zhechengli@microsoft.com

fixes #1087

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This code change fixes the bug that UDP services would trigger unnecessary LoadBalancer updates. The root cause is that a field not working for non-TCP protocols is considered.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @lzhecheng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Coverage decreased (-0.01%) to 80.036% when pulling fe0994b on lzhecheng:fix-enabletcpreset into 6c818cc on kubernetes-sigs:master.

[feiskyer]

/ok-to-test

[feiskyer]

Could you add a release note?

[nilo19]

/retest

[lzhecheng]

Could you add a release note?

Sure.

[feiskyer]

Thanks for the fix.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lzhecheng]

/test pull-cloud-provider-azure-e2e-ccm-capz

[lzhecheng]

/test pull-cloud-provider-azure-e2e-ccm-capz

[feiskyer]

/cherry-pick release-1.23
/cherry-pick release-1.1
/cherry-pick release-1.0
/cherry-pick release-0.7

[k8s-infra-cherrypick-robot]

@feiskyer: #1090 failed to apply on top of branch "release-1.23":

Applying: Fix incorrect EnableTCPReset for non-TCP protocols
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix incorrect EnableTCPReset for non-TCP protocols
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.23
/cherry-pick release-1.1
/cherry-pick release-1.0
/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nilo19]

@feiskyer the cherry-pick command needs to be invoked one by one.

[nilo19]

@lzhecheng looks we need to do the manual cherry-picks.