fix: add http timeout to avoid connection stuck (#8383)

kubernetes-sigs · Feb 21, 2025 · efd34de · efd34de
1 parent debe0f5
commit efd34de
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/pkg/azclient/factory_conf.go b/pkg/azclient/factory_conf.go
@@ -21,6 +21,7 @@ import (
 	"net/http"
 	"strings"
 	"sync"
+	"time"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/policy"
 
@@ -39,6 +40,7 @@ func init() {
 				Transport: utils.DefaultTransport,
 				PoolSize:  100,
 			}),
+			Timeout: time.Minute,
 		}
 	})
 }

diff --git a/pkg/azclient/utils/options.go b/pkg/azclient/utils/options.go
@@ -55,6 +55,7 @@ func GetDefaultAzCoreClientOption() policy.ClientOptions {
 		},
 		Transport: &http.Client{
 			Transport: DefaultTransport,
+			Timeout:   time.Minute,
 		},
 		TracingProvider:                 TracingProvider,
 		Cloud:                           cloud.AzurePublic,

diff --git a/pkg/provider/azure_instance_metadata.go b/pkg/provider/azure_instance_metadata.go
@@ -24,6 +24,7 @@ import (
 	"io"
 	"net/http"
 	"strings"
+	"time"
 
 	"k8s.io/klog/v2"
 
@@ -191,7 +192,7 @@ func (ims *InstanceMetadataService) getInstanceMetadata(_ string) (*InstanceMeta
 	q.Add("api-version", consts.ImdsInstanceAPIVersion)
 	req.URL.RawQuery = q.Encode()
 
-	client := &http.Client{}
+	client := &http.Client{Timeout: time.Minute}
 	resp, err := client.Do(req)
 	if err != nil {
 		return nil, err
@@ -229,7 +230,7 @@ func (ims *InstanceMetadataService) getLoadBalancerMetadata() (*LoadBalancerMeta
 	q.Add("api-version", consts.ImdsLoadBalancerAPIVersion)
 	req.URL.RawQuery = q.Encode()
 
-	client := &http.Client{}
+	client := &http.Client{Timeout: time.Minute}
 	resp, err := client.Do(req)
 	if err != nil {
 		return nil, err