Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support install specific blobfuse version using blobfuse-proxy #857

Merged
merged 5 commits into from
Apr 4, 2023
Merged

feat: support install specific blobfuse version using blobfuse-proxy #857

merged 5 commits into from
Apr 4, 2023

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature
/kind bug

What this PR does / why we need it:
fix: support install specific blobfuse version using blobfuse-proxy

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: support install specific blobfuse version using blobfuse-proxy

@andyzhangx andyzhangx requested a review from cvvz March 27, 2023 04:02
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@andyzhangx andyzhangx changed the title feat: support install specific blobfuse version using blobfuse-proxy [WIP]feat: support install specific blobfuse version using blobfuse-proxy Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2023
@andyzhangx andyzhangx force-pushed the proxy-install-specific-version branch from 8f67cb1 to 7745036 Compare March 27, 2023 08:16
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2023
cvvz
cvvz reviewed Mar 28, 2023
View reviewed changes
@andyzhangx andyzhangx force-pushed the proxy-install-specific-version branch from e444bd5 to 173ff0d Compare March 29, 2023 08:05
@andyzhangx
chore: add chart file change for blobfuse2 install
0211b25 
fix comments

remove fuse3 install
@andyzhangx andyzhangx force-pushed the proxy-install-specific-version branch 3 times, most recently from 9593bbe to 4823f43 Compare April 1, 2023 15:41
@andyzhangx
chore: install fuse on Ubuntu 18.04
d1b9f49 
fix shell

fix typo

chore: install blobfuse package by default
@andyzhangx andyzhangx force-pushed the proxy-install-specific-version branch from 4823f43 to d1b9f49 Compare April 2, 2023 01:15
@andyzhangx andyzhangx changed the title [WIP]feat: support install specific blobfuse version using blobfuse-proxy feat: support install specific blobfuse version using blobfuse-proxy Apr 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2023
@andyzhangx
Copy link
Member Author

/retest

2 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx force-pushed the proxy-install-specific-version branch from 7815370 to 2837879 Compare April 3, 2023 14:39
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx force-pushed the proxy-install-specific-version branch from 2837879 to f329db1 Compare April 4, 2023 02:27
@andyzhangx andyzhangx force-pushed the proxy-install-specific-version branch from f329db1 to 533af87 Compare April 4, 2023 02:30
@cvvz
Copy link
Member

cvvz commented Apr 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 07f79d4 into kubernetes-sigs:master Apr 4, 2023
This was referenced May 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvz cvvz cvvz left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@cvvz cvvz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @cvvz @k8s-ci-robot