Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set read-ahead for nfs mount #759

Merged
merged 1 commit into from
Oct 8, 2022
Merged

feat: set read-ahead for nfs mount #759

merged 1 commit into from
Oct 8, 2022

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Sep 20, 2022 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

performance test result

before

io wait is high and cpu usage is low

image

cache hits times is low

image

vfs_read execution time

image

after

io wait is 0and cpu usage is higher than before

image

cache hits times is higher

image

vfs_read execution time

image

Release note:

none

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2022
andyzhangx
andyzhangx reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2022
@cvvz cvvz changed the title set read-ahead [WIP]set read-ahead Sep 20, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2022
@cvvz cvvz changed the title [WIP]set read-ahead set read-ahead Oct 8, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2022
@cvvz
Copy link
Member Author

cvvz commented Oct 8, 2022

@andyzhangx PTAL

@andyzhangx
Copy link
Member

@andyzhangx PTAL

@cvvz it works now? what's the change later?

@cvvz
Copy link
Member Author

cvvz commented Oct 8, 2022

Yes, absolute path of awk is different in different Linux distribution and version, AKS is using Ubuntu 18.04 and /bin/awk is not right executable path.

@cvvz
Copy link
Member Author

cvvz commented Oct 8, 2022 •
edited
Loading

The script is now work for different Linux distribution version

@cvvz
Copy link
Member Author

cvvz commented Oct 8, 2022

They have updated the documentation to reflect this.
Linux NFS read-ahead best practices for Azure NetApp Files - Session slots and slot table entries | Microsoft Learn

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2022
@cvvz cvvz requested review from andyzhangx and removed request for ZeroMagic October 8, 2022 10:10
@andyzhangx andyzhangx changed the title set read-ahead feat: set read-ahead for nfs mount Oct 8, 2022
andyzhangx
andyzhangx approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
pls squash all commits

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2022
@cvvz
set read-ahead
590af59 
use awk absolute path

add flag control

add log
andyzhangx
andyzhangx approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87e3ec7 into kubernetes-sigs:master Oct 8, 2022
@cvvz cvvz mentioned this pull request Nov 6, 2023
Closed
4 tasks
@cvvz cvvz mentioned this pull request Jan 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvvz @k8s-ci-robot @andyzhangx