feat: always update blobfuse-proxy service in driver init #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
8a9237c to
ce0f21f
Compare
ce0f21f to
4243d05
Compare
|
@cvvz for review |
cvvz
reviewed
Sep 5, 2022
| then | ||
| if [ -f "/host/usr/lib/systemd/system/blobfuse-proxy.service" ];then | ||
| echo "stop blobfuse-proxy.service ..." | ||
| $HOST_CMD systemctl stop blobfuse-proxy.service |
There was a problem hiding this comment.
Suggest comparing the new blobfuse-proxy and blobfuse-proxy.service file with the old ones, if there is no change, we can avoid stopping it every time.
4 tasks
|
close this PR since it's already addressed by #761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: always update blobfuse-proxy service in driver init
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: