Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support workload identity setting in static PV mount #1204

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Jan 3, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
support workload identity setting in static PV mount

Which issue(s) this PR fixes:

Fixes
Azure/AKS#3432
Azure/azure-storage-fuse#1049 (comment)

Requirements:

Special notes for your reviewer:

Here are the csi driver's logs:

  • When mount static PV, first we skip NodeStageVolume, then we use service account token to get the account key during NodePublishVolume
csi-blob-node-q42vs blob I0103 04:30:49.306422  212626 utils.go:103] GRPC call: /csi.v1.Node/NodeStageVolume
csi-blob-node-q42vs blob I0103 04:30:49.306450  212626 utils.go:104] GRPC request: {"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/blob.csi.azure.com/e53ce882ae47f30739a21cc04a37ac4a14a19894e1551e7d78909e7e1d52d167/globalmount","volume_capability":{"AccessType":{"Mount":{"mount_flags":["-o allow_other","--file-cache-timeout-in-seconds=120"]}},"access_mode":{"mode":5}},"volume_context":{"clientID":"e600b81e-7cd9-4b46-8dd4-fd423f8c72f3","containerName":"test","resourcegroup":"weizhichen-blob-test","storageaccount":"weizhichenblobaccount"},"volume_id":"unique_volume_id"}
csi-blob-node-q42vs blob I0103 04:30:49.306613  212626 nodeserver.go:257] Skip NodeStageVolume for volume(unique_volume_id) since clientID e600b81e-7cd9-4b46-8dd4-fd423f8c72f3 is provided but service account token is empty
csi-blob-node-q42vs blob I0103 04:30:49.306624  212626 utils.go:110] GRPC response: {}
csi-blob-node-q42vs blob I0103 04:30:49.344376  212626 utils.go:103] GRPC call: /csi.v1.Node/NodePublishVolume
csi-blob-node-q42vs blob I0103 04:30:49.344424  212626 utils.go:104] GRPC request: {"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/blob.csi.azure.com/e53ce882ae47f30739a21cc04a37ac4a14a19894e1551e7d78909e7e1d52d167/globalmount","target_path":"/var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount","volume_capability":{"AccessType":{"Mount":{"mount_flags":["-o allow_other","--file-cache-timeout-in-seconds=120"]}},"access_mode":{"mode":5}},"volume_context":{"clientID":"e600b81e-7cd9-4b46-8dd4-fd423f8c72f3","containerName":"test","csi.storage.k8s.io/ephemeral":"false","csi.storage.k8s.io/pod.name":"statefulset-blob-0","csi.storage.k8s.io/pod.namespace":"default","csi.storage.k8s.io/pod.uid":"c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c","csi.storage.k8s.io/serviceAccount.name":"weizhichen","csi.storage.k8s.io/serviceAccount.tokens":"{\"api://AzureADTokenExchange\":{\"token\":\"eyJhbGciOiJSUzI1NiIsImtpZCI6IlZXXzNqVjMxQXNZS29FM0xjWlQzaTdFaGZBRVNyRTIyNkNPaERWTmFCNkkifQ.eyJhdWQiOlsiYXBpOi8vQXp1cmVBRFRva2VuRXhjaGFuZ2UiXSwiZXhwIjoxNzA0MjU5ODQ5LCJpYXQiOjE3MDQyNTYyNDksImlzcyI6Imh0dHBzOi8vZWFzdHVzLm9pYy5wcm9kLWFrcy5henVyZS5jb20vNzJmOTg4YmYtODZmMS00MWFmLTkxYWItMmQ3Y2QwMTFkYjQ3L2Y5MDMwZDdlLWQ4OTYtNDNiYi1iMWEwLTI1ZmM0OTkzNDk1NS8iLCJrdWJlcm5ldGVzLmlvIjp7Im5hbWVzcGFjZSI6ImRlZmF1bHQiLCJwb2QiOnsibmFtZSI6InN0YXRlZnVsc2V0LWJsb2ItMCIsInVpZCI6ImM0MmFhN2ViLTViMGYtNDIwOS05OTdjLTlmZTZkYmJkMGU3YyJ9LCJzZXJ2aWNlYWNjb3VudCI6eyJuYW1lIjoid2VpemhpY2hlbiIsInVpZCI6IjAxODMxYmViLTE2NzctNDBkMy05ZGI0LTAwNWU0YjRlYTQwYyJ9fSwibmJmIjoxNzA0MjU2MjQ5LCJzdWIiOiJzeXN0ZW06c2VydmljZWFjY291bnQ6ZGVmYXVsdDp3ZWl6aGljaGVuIn0.VLeCQEgEH-BvFBJxLujXtfGFk3PI2BMd19_jy7orCWfuZPkmmWBcNJ_n8yFVc5OPr23ZaaUQ1FotjCR1LxS5N5Qn3io1PNp93meREl7sqkry75moskzRukg4RNw87x4gir9RRuB51HgwSh1JYQMEkO2dBkcuMm14BGNAb0W3eG7ePzz_N9HN-B82vsBaCkNErELIfyQKvIWY2DbFUSl7OQUZcOwEMI09vuG6kmLHu99ejcJarEC1DeMmmSp4iMLExvICLnH49B_AR8uzbxL3D_xF6m4JqOgLakPCn6iddURptzRIlea0TvLentJqC12uRtR0-9YYHioYokla9FpU16iUPQTbBlpk2GG4mXnMcPDf0Z1FZEdlVOOx4q97Q5C36T2pyU2gAsZGIpidLcmFI_HHJoure1Ws6jNMjxpmfDZJlfouWKuJbkwOoPpwY6Kj3Nj4qED6tFYRmiFskpdQ4_LuIr9_2ogEdYiQAJL6He3rKlsfrA9FM1g2o4zBIy7TfIUwx-_MqHSM-NoXHVN8ky1L8XCXV3ntC8wO61JcOvtdMt6mxATcF6UbE6JBPEhjhqNFmyPcqq76THP1R861R-au_KTynbT484U_OHbYivML5oO2SUPfibzraSmpUQVsWiWj-gqO2bHgMsvbsgcQ3QmDnYInpAQzdqJFJzM1FSg\",\"expirationTimestamp\":\"2024-01-03T05:30:49Z\"}}","resourcegroup":"weizhichen-blob-test","storageaccount":"weizhichenblobaccount"},"volume_id":"unique_volume_id"}
csi-blob-node-q42vs blob I0103 04:30:49.344623  212626 nodeserver.go:86] NodePublishVolume: volume(unique_volume_id) mount on /var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount with service account token, clientID: e600b81e-7cd9-4b46-8dd4-fd423f8c72f3
csi-blob-node-q42vs blob I0103 04:30:49.345059  212626 blob.go:416] parsing volumeID(unique_volume_id) return with error: error parsing volume id: "unique_volume_id", should at least contain two #
csi-blob-node-q42vs blob I0103 04:30:49.345090  212626 blob.go:497] volumeID(unique_volume_id) authEnv: []
csi-blob-node-q42vs blob I0103 04:30:49.345105  212626 blob.go:522] clientID(e600b81e-7cd9-4b46-8dd4-fd423f8c72f3) is specified, use service account token to get account key
csi-blob-node-q42vs blob I0103 04:30:50.241518  212626 nodeserver.go:393] target /var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount
csi-blob-node-q42vs blob protocol
csi-blob-node-q42vs blob
csi-blob-node-q42vs blob volumeId unique_volume_id
csi-blob-node-q42vs blob context map[clientID:e600b81e-7cd9-4b46-8dd4-fd423f8c72f3 containerName:test csi.storage.k8s.io/ephemeral:false csi.storage.k8s.io/pod.name:statefulset-blob-0 csi.storage.k8s.io/pod.namespace:default csi.storage.k8s.io/pod.uid:c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c csi.storage.k8s.io/serviceAccount.name:weizhichen csi.storage.k8s.io/serviceAccount.tokens:{"api://AzureADTokenExchange":{"token":"eyJhbGciOiJSUzI1NiIsImtpZCI6IlZXXzNqVjMxQXNZS29FM0xjWlQzaTdFaGZBRVNyRTIyNkNPaERWTmFCNkkifQ.eyJhdWQiOlsiYXBpOi8vQXp1cmVBRFRva2VuRXhjaGFuZ2UiXSwiZXhwIjoxNzA0MjU5ODQ5LCJpYXQiOjE3MDQyNTYyNDksImlzcyI6Imh0dHBzOi8vZWFzdHVzLm9pYy5wcm9kLWFrcy5henVyZS5jb20vNzJmOTg4YmYtODZmMS00MWFmLTkxYWItMmQ3Y2QwMTFkYjQ3L2Y5MDMwZDdlLWQ4OTYtNDNiYi1iMWEwLTI1ZmM0OTkzNDk1NS8iLCJrdWJlcm5ldGVzLmlvIjp7Im5hbWVzcGFjZSI6ImRlZmF1bHQiLCJwb2QiOnsibmFtZSI6InN0YXRlZnVsc2V0LWJsb2ItMCIsInVpZCI6ImM0MmFhN2ViLTViMGYtNDIwOS05OTdjLTlmZTZkYmJkMGU3YyJ9LCJzZXJ2aWNlYWNjb3VudCI6eyJuYW1lIjoid2VpemhpY2hlbiIsInVpZCI6IjAxODMxYmViLTE2NzctNDBkMy05ZGI0LTAwNWU0YjRlYTQwYyJ9fSwibmJmIjoxNzA0MjU2MjQ5LCJzdWIiOiJzeXN0ZW06c2VydmljZWFjY291bnQ6ZGVmYXVsdDp3ZWl6aGljaGVuIn0.VLeCQEgEH-BvFBJxLujXtfGFk3PI2BMd19_jy7orCWfuZPkmmWBcNJ_n8yFVc5OPr23ZaaUQ1FotjCR1LxS5N5Qn3io1PNp93meREl7sqkry75moskzRukg4RNw87x4gir9RRuB51HgwSh1JYQMEkO2dBkcuMm14BGNAb0W3eG7ePzz_N9HN-B82vsBaCkNErELIfyQKvIWY2DbFUSl7OQUZcOwEMI09vuG6kmLHu99ejcJarEC1DeMmmSp4iMLExvICLnH49B_AR8uzbxL3D_xF6m4JqOgLakPCn6iddURptzRIlea0TvLentJqC12uRtR0-9YYHioYokla9FpU16iUPQTbBlpk2GG4mXnMcPDf0Z1FZEdlVOOx4q97Q5C36T2pyU2gAsZGIpidLcmFI_HHJoure1Ws6jNMjxpmfDZJlfouWKuJbkwOoPpwY6Kj3Nj4qED6tFYRmiFskpdQ4_LuIr9_2ogEdYiQAJL6He3rKlsfrA9FM1g2o4zBIy7TfIUwx-_MqHSM-NoXHVN8ky1L8XCXV3ntC8wO61JcOvtdMt6mxATcF6UbE6JBPEhjhqNFmyPcqq76THP1R861R-au_KTynbT484U_OHbYivML5oO2SUPfibzraSmpUQVsWiWj-gqO2bHgMsvbsgcQ3QmDnYInpAQzdqJFJzM1FSg","expirationTimestamp":"2024-01-03T05:30:49Z"}} resourcegroup:weizhichen-blob-test storageaccount:weizhichenblobaccount]
csi-blob-node-q42vs blob mountflags [-o allow_other --file-cache-timeout-in-seconds=120]
csi-blob-node-q42vs blob mountOptions [-o allow_other --file-cache-timeout-in-seconds=120 --empty-dir-check=false --tmp-path=/mnt/unique_volume_id --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10]
csi-blob-node-q42vs blob args /var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount -o allow_other --file-cache-timeout-in-seconds=120 --empty-dir-check=false --tmp-path=/mnt/unique_volume_id --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10
csi-blob-node-q42vs blob serverAddress weizhichenblobaccount.blob.core.windows.net
csi-blob-node-q42vs blob I0103 04:30:50.241735  212626 nodeserver.go:168] start connecting to blobfuse proxy, protocol: , args: /var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount -o allow_other --file-cache-timeout-in-seconds=120 --empty-dir-check=false --tmp-path=/mnt/unique_volume_id --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10
csi-blob-node-q42vs blob I0103 04:30:50.247380  212626 nodeserver.go:177] begin to mount with blobfuse proxy, protocol: , args: /var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount -o allow_other --file-cache-timeout-in-seconds=120 --empty-dir-check=false --tmp-path=/mnt/unique_volume_id --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10
csi-blob-node-q42vs blob I0103 04:30:50.498419  212626 mount_linux.go:282] Detected umount with safe 'not mounted' behavior
csi-blob-node-q42vs blob I0103 04:30:50.499044  212626 nodeserver.go:666] blobfuse mount at /var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount success
csi-blob-node-q42vs blob I0103 04:30:50.499088  212626 nodeserver.go:451] volume(unique_volume_id) mount on "/var/lib/kubelet/pods/c42aa7eb-5b0f-4209-997c-9fe6dbbd0e7c/volumes/kubernetes.io~csi/pv-blob/mount" succeeded
csi-blob-node-q42vs blob I0103 04:30:50.499138  212626 azure_metrics.go:115] "Observed Request Latency" latency_seconds=1.15446237 request="blob_csi_driver_node_stage_volume" resource_group="mc_weizhichen-aks_weizhichen-aks_eastus" subscription_id="" source="blob.csi.azure.com" volumeid="unique_volume_id" result_code="failed_csi_driver_node_stage_volume"
csi-blob-node-q42vs blob I0103 04:30:50.499159  212626 utils.go:110] GRPC response: {}
  • When mount ephemeral volume, we use service account token to get the account key during NodePublishVolume
csi-blob-node-q42vs blob I0103 04:32:15.552665  212626 utils.go:103] GRPC call: /csi.v1.Node/NodePublishVolume
csi-blob-node-q42vs blob I0103 04:32:15.552690  212626 utils.go:104] GRPC request: {"target_path":"/var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":7}},"volume_context":{"clientID":"e600b81e-7cd9-4b46-8dd4-fd423f8c72f3","containerName":"test","csi.storage.k8s.io/ephemeral":"true","csi.storage.k8s.io/pod.name":"nginx-blobfuse-inline-volume","csi.storage.k8s.io/pod.namespace":"default","csi.storage.k8s.io/pod.uid":"d616c003-d12e-48b1-b636-320be4445eb9","csi.storage.k8s.io/serviceAccount.name":"weizhichen","csi.storage.k8s.io/serviceAccount.tokens":"{\"api://AzureADTokenExchange\":{\"token\":\"eyJhbGciOiJSUzI1NiIsImtpZCI6IlZXXzNqVjMxQXNZS29FM0xjWlQzaTdFaGZBRVNyRTIyNkNPaERWTmFCNkkifQ.eyJhdWQiOlsiYXBpOi8vQXp1cmVBRFRva2VuRXhjaGFuZ2UiXSwiZXhwIjoxNzA0MjU5OTM1LCJpYXQiOjE3MDQyNTYzMzUsImlzcyI6Imh0dHBzOi8vZWFzdHVzLm9pYy5wcm9kLWFrcy5henVyZS5jb20vNzJmOTg4YmYtODZmMS00MWFmLTkxYWItMmQ3Y2QwMTFkYjQ3L2Y5MDMwZDdlLWQ4OTYtNDNiYi1iMWEwLTI1ZmM0OTkzNDk1NS8iLCJrdWJlcm5ldGVzLmlvIjp7Im5hbWVzcGFjZSI6ImRlZmF1bHQiLCJwb2QiOnsibmFtZSI6Im5naW54LWJsb2JmdXNlLWlubGluZS12b2x1bWUiLCJ1aWQiOiJkNjE2YzAwMy1kMTJlLTQ4YjEtYjYzNi0zMjBiZTQ0NDVlYjkifSwic2VydmljZWFjY291bnQiOnsibmFtZSI6IndlaXpoaWNoZW4iLCJ1aWQiOiIwMTgzMWJlYi0xNjc3LTQwZDMtOWRiNC0wMDVlNGI0ZWE0MGMifX0sIm5iZiI6MTcwNDI1NjMzNSwic3ViIjoic3lzdGVtOnNlcnZpY2VhY2NvdW50OmRlZmF1bHQ6d2VpemhpY2hlbiJ9.W-kstfTbgKC1B6MrqAqtHeGvYgTnuJlcTLcmTcy_pJM5FLw0dhxBttCDQhVo_yKr-fNmi7Y__wEEFyfyQp8UEP6BOUX3HuElat_0nDlHClUS9r-ydf_hevkWWALSfx_I8WGJFADgXZlMkY3njxsk6uY_Uq8TvWdxaR2um7JeyzGbLwvYTis6Ifk8HKDRxvID9CBxvvv3cccS3HqVCibBiEUyQT7VkAGoSkgXXRIJkS6dwLmRRfSuRbkpatlRcwiBbcIBVvLOY5Qvg77ReWIP3GJn_j2R-RiFXX47RL8wzUR-ia8MhOQi9iq76Qh0bf7WTr6kkNANX8inm0EcekfcSf9CxOzAE96xhBrdvkn5jEOs8shsEspJmveFxmyaX_ZEVtFuE3FDe1A_oXVggywdwoAoV9sCI7GMWufjA-oRshCSOWX0h54hMWgmzAFVHtWHw2Rkdz8WAXrI2kQ6MHQoPD33nteTvv4MBYliUjgxH1TgsazWU-OmWcfhC1u16Rl_KaVPT6Q7giCa-p8OZQIsm2oGZqMJdEzqXcZZtpXT-bLNgWoUD-2RjOQ8ae3wZkKYgPktIpojwQuh8qGmFHUacBaeQjkoNz0vQeKNFHG8pIGGswxb0EOh7iaaTk31Ng13wRn8lDa0An2ILN579mKeK8E9mBaDev_LgebJcn-E4PI\",\"expirationTimestamp\":\"2024-01-03T05:32:15Z\"}}","resourcegroup":"weizhichen-blob-test","storageaccount":"weizhichenblobaccount"},"volume_id":"csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e"}
csi-blob-node-q42vs blob I0103 04:32:15.552869  212626 nodeserver.go:86] NodePublishVolume: volume(csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e) mount on /var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount with service account token, clientID: e600b81e-7cd9-4b46-8dd4-fd423f8c72f3
csi-blob-node-q42vs blob I0103 04:32:15.554652  212626 blob.go:416] parsing volumeID(csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e) return with error: error parsing volume id: "csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e", should at least contain two #
csi-blob-node-q42vs blob I0103 04:32:15.554704  212626 blob.go:497] volumeID(csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e) authEnv: []
csi-blob-node-q42vs blob I0103 04:32:15.554720  212626 blob.go:522] clientID(e600b81e-7cd9-4b46-8dd4-fd423f8c72f3) is specified, use service account token to get account key
csi-blob-node-q42vs blob I0103 04:32:17.772718  212626 nodeserver.go:393] target /var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount
csi-blob-node-q42vs blob protocol
csi-blob-node-q42vs blob
csi-blob-node-q42vs blob volumeId csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e
csi-blob-node-q42vs blob context map[clientID:e600b81e-7cd9-4b46-8dd4-fd423f8c72f3 containerName:test csi.storage.k8s.io/ephemeral:true csi.storage.k8s.io/pod.name:nginx-blobfuse-inline-volume csi.storage.k8s.io/pod.namespace:default csi.storage.k8s.io/pod.uid:d616c003-d12e-48b1-b636-320be4445eb9 csi.storage.k8s.io/serviceAccount.name:weizhichen csi.storage.k8s.io/serviceAccount.tokens:{"api://AzureADTokenExchange":{"token":"eyJhbGciOiJSUzI1NiIsImtpZCI6IlZXXzNqVjMxQXNZS29FM0xjWlQzaTdFaGZBRVNyRTIyNkNPaERWTmFCNkkifQ.eyJhdWQiOlsiYXBpOi8vQXp1cmVBRFRva2VuRXhjaGFuZ2UiXSwiZXhwIjoxNzA0MjU5OTM1LCJpYXQiOjE3MDQyNTYzMzUsImlzcyI6Imh0dHBzOi8vZWFzdHVzLm9pYy5wcm9kLWFrcy5henVyZS5jb20vNzJmOTg4YmYtODZmMS00MWFmLTkxYWItMmQ3Y2QwMTFkYjQ3L2Y5MDMwZDdlLWQ4OTYtNDNiYi1iMWEwLTI1ZmM0OTkzNDk1NS8iLCJrdWJlcm5ldGVzLmlvIjp7Im5hbWVzcGFjZSI6ImRlZmF1bHQiLCJwb2QiOnsibmFtZSI6Im5naW54LWJsb2JmdXNlLWlubGluZS12b2x1bWUiLCJ1aWQiOiJkNjE2YzAwMy1kMTJlLTQ4YjEtYjYzNi0zMjBiZTQ0NDVlYjkifSwic2VydmljZWFjY291bnQiOnsibmFtZSI6IndlaXpoaWNoZW4iLCJ1aWQiOiIwMTgzMWJlYi0xNjc3LTQwZDMtOWRiNC0wMDVlNGI0ZWE0MGMifX0sIm5iZiI6MTcwNDI1NjMzNSwic3ViIjoic3lzdGVtOnNlcnZpY2VhY2NvdW50OmRlZmF1bHQ6d2VpemhpY2hlbiJ9.W-kstfTbgKC1B6MrqAqtHeGvYgTnuJlcTLcmTcy_pJM5FLw0dhxBttCDQhVo_yKr-fNmi7Y__wEEFyfyQp8UEP6BOUX3HuElat_0nDlHClUS9r-ydf_hevkWWALSfx_I8WGJFADgXZlMkY3njxsk6uY_Uq8TvWdxaR2um7JeyzGbLwvYTis6Ifk8HKDRxvID9CBxvvv3cccS3HqVCibBiEUyQT7VkAGoSkgXXRIJkS6dwLmRRfSuRbkpatlRcwiBbcIBVvLOY5Qvg77ReWIP3GJn_j2R-RiFXX47RL8wzUR-ia8MhOQi9iq76Qh0bf7WTr6kkNANX8inm0EcekfcSf9CxOzAE96xhBrdvkn5jEOs8shsEspJmveFxmyaX_ZEVtFuE3FDe1A_oXVggywdwoAoV9sCI7GMWufjA-oRshCSOWX0h54hMWgmzAFVHtWHw2Rkdz8WAXrI2kQ6MHQoPD33nteTvv4MBYliUjgxH1TgsazWU-OmWcfhC1u16Rl_KaVPT6Q7giCa-p8OZQIsm2oGZqMJdEzqXcZZtpXT-bLNgWoUD-2RjOQ8ae3wZkKYgPktIpojwQuh8qGmFHUacBaeQjkoNz0vQeKNFHG8pIGGswxb0EOh7iaaTk31Ng13wRn8lDa0An2ILN579mKeK8E9mBaDev_LgebJcn-E4PI","expirationTimestamp":"2024-01-03T05:32:15Z"}} resourcegroup:weizhichen-blob-test storageaccount:weizhichenblobaccount]
csi-blob-node-q42vs blob mountflags []
csi-blob-node-q42vs blob mountOptions [ --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10 --empty-dir-check=false --tmp-path=/mnt/csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e]
csi-blob-node-q42vs blob args /var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount  --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10 --empty-dir-check=false --tmp-path=/mnt/csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e
csi-blob-node-q42vs blob serverAddress weizhichenblobaccount.blob.core.windows.net
csi-blob-node-q42vs blob I0103 04:32:17.772775  212626 nodeserver.go:168] start connecting to blobfuse proxy, protocol: , args: /var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount  --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10 --empty-dir-check=false --tmp-path=/mnt/csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e
csi-blob-node-q42vs blob I0103 04:32:17.773446  212626 nodeserver.go:177] begin to mount with blobfuse proxy, protocol: , args: /var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount  --container-name=test --pre-mount-validate=true --use-https=true --cancel-list-on-mount-seconds=10 --empty-dir-check=false --tmp-path=/mnt/csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e
csi-blob-node-q42vs blob I0103 04:32:17.998096  212626 mount_linux.go:282] Detected umount with safe 'not mounted' behavior
csi-blob-node-q42vs blob I0103 04:32:17.998505  212626 nodeserver.go:666] blobfuse mount at /var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount success
csi-blob-node-q42vs blob I0103 04:32:17.998546  212626 nodeserver.go:451] volume(csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e) mount on "/var/lib/kubelet/pods/d616c003-d12e-48b1-b636-320be4445eb9/volumes/kubernetes.io~csi/persistent-storage/mount" succeeded
csi-blob-node-q42vs blob I0103 04:32:17.998601  212626 azure_metrics.go:115] "Observed Request Latency" latency_seconds=2.4456819960000002 request="blob_csi_driver_node_stage_volume" resource_group="mc_weizhichen-aks_weizhichen-aks_eastus" subscription_id="" source="blob.csi.azure.com" volumeid="csi-66bb5520d0d665120ede3f1f6eb822e6b2ce2e3c81c1e6b830a3100698736c1e" result_code="failed_csi_driver_node_stage_volume"
csi-blob-node-q42vs blob I0103 04:32:17.998631  212626 utils.go:110] GRPC response: {}

Release note:

feat: support workload identity setting in static PV mount on AKS

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 3, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2024
@andyzhangx
Copy link
Member

could you fix the chart error? thanks.

pkg/blob/nodeserver.go Outdated Show resolved Hide resolved
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 237ef66 into kubernetes-sigs:master Jan 5, 2024
22 checks passed
@andyzhangx
Copy link
Member

/cherrypick release-1.23

@k8s-infra-cherrypick-robot

@andyzhangx: #1204 failed to apply on top of branch "release-1.23":

Applying: feat: support workload identity setting in static PV mount
.git/rebase-apply/patch:42: trailing whitespace.
> Note: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	pkg/blob/blob.go
M	pkg/blob/nodeserver.go
M	vendor/modules.txt
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_common.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer_healthprobe.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_storageaccount.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_storageaccount.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer_healthprobe.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_common.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_common.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure.go
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging pkg/blob/nodeserver.go
CONFLICT (content): Merge conflict in pkg/blob/nodeserver.go
Auto-merging pkg/blob/blob.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: support workload identity setting in static PV mount
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member

@cvvz can you cherrypick this PR to release-1.23? thanks.

cvvz added a commit to cvvz/blob-csi-driver that referenced this pull request Jan 6, 2024
…s-sigs#1204)

* feat: support workload identity setting in static PV mount

* fix
cvvz added a commit to cvvz/blob-csi-driver that referenced this pull request Jan 8, 2024
…s-sigs#1204)

* feat: support workload identity setting in static PV mount

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants