Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable fsGroup external test for nfs #820

Merged
merged 1 commit into from
May 4, 2022
Merged

test: enable fsGroup external test for nfs #820

merged 1 commit into from
May 4, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind test

What this PR does / why we need it:
test: enable fsGroup external test for nfs

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx closed this Dec 19, 2021
@andyzhangx andyzhangx reopened this Dec 19, 2021
@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-external-e2e-nfs

1 similar comment
@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-external-e2e-nfs

@gnufied
Copy link
Contributor

gnufied commented Feb 25, 2022

How does fsGroup work for NFS @andyzhangx ? Is kubelet changing the permissions recursively.

@andyzhangx
Copy link
Member Author

How does fsGroup work for NFS @andyzhangx ? Is kubelet changing the permissions recursively.

@gnufied yes, for nfs csi driver, it's already supported: https://github.com/kubernetes-csi/csi-driver-nfs/blob/master/test/external-e2e/testdriver.yaml#L13, while for this azure file driver, there is a block issue related to nfs implementation on azure file: #682

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-file
/test pull-kubernetes-e2e-capz-azure-file-windows

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-capz-azure-file-windows

@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-e2e-migration
/test pull-azurefile-csi-driver-e2e-migration-windows

@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-e2e-migration-windows

@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-e2e-capz-windows

@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-e2e-migration-windows

1 similar comment
@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-e2e-migration-windows

@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-external-e2e-nfs

2 similar comments
@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-external-e2e-nfs

@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-external-e2e-nfs

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 8, 2022 •
edited
Loading

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-azure-file-windows 34a83f4 link false /test pull-kubernetes-e2e-capz-azure-file-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-external-e2e-nfs

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 2e90fdf into master May 4, 2022
@andyzhangx andyzhangx deleted the nfs-fsgroup-test branch May 29, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @gnufied