Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track2 sdk:migrate azfile data plane client to track2 one #2116

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Track2 sdk:migrate azfile data plane client to track2 one #2116

merged 1 commit into from
Sep 29, 2024

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Track2 sdk:migrate azfile data plane client to track2 one
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2024
@MartinForReal MartinForReal force-pushed the master branch 4 times, most recently from b3a649b to 44cf32f Compare September 25, 2024 05:42
@MartinForReal
Copy link
Contributor Author

/retest

3 similar comments
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@andyzhangx
Copy link
Member

/retest

@MartinForReal MartinForReal force-pushed the master branch 4 times, most recently from e08fd62 to dd3dc43 Compare September 26, 2024 14:06
@MartinForReal
migrate azfile data plane client to track2 one
480d729 
Signed-off-by: Fan Shang Xiang <shafan@microsoft.com>
@MartinForReal
Copy link
Contributor Author

/retest

@cvvz
Copy link
Member

cvvz commented Sep 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2024
feiskyer
feiskyer approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cvvz, feiskyer, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 601b303 into kubernetes-sigs:master Sep 29, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@cvvz cvvz cvvz approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@cvvz cvvz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinForReal @andyzhangx @cvvz @k8s-ci-robot @feiskyer