chore: add flag for azcopy use sas token by default #1675
Conversation
|
Hi @umagnus. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/azurefile/azurefile_options.go
Outdated
| @@ -81,6 +82,7 @@ func (o *DriverOptions) AddFlags() *flag.FlagSet { | |||
| fs.IntVar(&o.SasTokenExpirationMinutes, "sas-token-expiration-minutes", 1440, "sas token expiration minutes during volume cloning") | |||
| fs.StringVar(&o.KubeConfig, "kubeconfig", "", "Absolute path to the kubeconfig file. Required only when running out of cluster.") | |||
| fs.StringVar(&o.Endpoint, "endpoint", "unix://tmp/csi.sock", "CSI endpoint") | |||
| fs.BoolVar(&o.AzcopyUseSasToken, "azcopy-use-sas-token", true, "Whether to use SAS token for azcopy") | |||
There was a problem hiding this comment.
indicates whether SAS token should be used in azcopy based on volume clone and snapshot restore
cec78e9 to
3307293
Compare
|
/ok-to-test |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, umagnus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind test
What this PR does / why we need it:
test: add flag for azcopy use sas token by default
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: