Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: load config with configloader #1614

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Nov 29, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactor:load config with configloader
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

Signed-off-by: Fan Shang Xiang <fanshangxiang@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2023
@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied November 29, 2023 09:20
@andyzhangx
Copy link
Member

/retest

4 similar comments
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@andyzhangx
Copy link
Member

/retest

@MartinForReal
Copy link
Contributor Author

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@MartinForReal
Copy link
Contributor Author

/retest

1 similar comment
@andyzhangx
Copy link
Member

/retest

@MartinForReal
Copy link
Contributor Author

/test pull-azurefile-csi-driver-external-e2e-nfs --


@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/test pull-azurefile-csi-driver-external-e2e-nfs --


@MartinForReal
Copy link
Contributor Author

/retest

3 similar comments
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

external e2e test failed as expected since cifs driver is not installed on 6.2.0-1016-azure, error msg:

Output: mount error: cifs filesystem not supported by the system
mount error(19): No such device
Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg)

@k8s-ci-robot
Copy link
Contributor

@MartinForReal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-migration 92efc76 link true /test pull-azurefile-csi-driver-e2e-migration
pull-azurefile-csi-driver-external-e2e-nfs 92efc76 link true /test pull-azurefile-csi-driver-external-e2e-nfs
pull-azurefile-csi-driver-external-e2e-smb 92efc76 link true /test pull-azurefile-csi-driver-external-e2e-smb
pull-azurefile-csi-driver-e2e-capz 92efc76 link true /test pull-azurefile-csi-driver-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit e39ec87 into kubernetes-sigs:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants